Bug 30468 - DAP stack trace should use frame filters
Summary: DAP stack trace should use frame filters
Status: RESOLVED FIXED
Alias: None
Product: gdb
Classification: Unclassified
Component: dap (show other bugs)
Version: HEAD
: P2 enhancement
Target Milestone: 14.1
Assignee: Tom Tromey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-05-19 14:38 UTC by Tom Tromey
Modified: 2023-07-10 19:18 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Tromey 2023-05-19 14:38:20 UTC 
Currently the DAP "stackTrace" request does not use frame filters.
However, it seems like it could.
Comment 1 Tom Tromey 2023-06-14 16:04:39 UTC 
I have a patch for this.
Comment 2 Sourceware Commits 2023-07-10 19:18:21 UTC 
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=5b86f10883d37e46aeeafa2818e227737d068dff

commit 5b86f10883d37e46aeeafa2818e227737d068dff
Author: Tom Tromey <tromey@adacore.com>
Date:   Wed Jun 14 06:09:23 2023 -0600

    Reimplement DAP stack traces using frame filters
    
    This reimplements DAP stack traces using frame filters.  This slightly
    simplifies the code, because frame filters and DAP were already doing
    some similar work.  This also renames RegisterReference and
    ScopeReference to make it clear that these are private (and so changes
    don't have to worry about other files).
    
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30468
Comment 3 Tom Tromey 2023-07-10 19:18:33 UTC 
Fixed.