Bug 30289 - [gdb/testsuite] Test run with editing off
Summary: [gdb/testsuite] Test run with editing off
Status: NEW
Alias: None
Product: gdb
Classification: Unclassified
Component: testsuite (show other bugs)
Version: HEAD
: P2 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-30 02:52 UTC by Tom de Vries
Modified: 2023-03-30 11:06 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom de Vries 2023-03-30 02:52:28 UTC
I wrote a board file (copied from readnow.exp) setting editing to off by default:
...
$ cat gdb/testsuite/boards/editing-off.exp 
  ...
load_board_description "local-board"

# Run all tests with editing off.
set GDBFLAGS "${GDBFLAGS} -iex \"set editing off\""

# This is based on baseboards/unix.exp.
# At the moment we only support systems that unix.exp supports.
load_generic_config "unix"
process_multilib_options ""
set found_gcc [find_gcc]
set found_gxx [find_g++]
set_board_info compiler "$found_gcc"
...

Results:
...
FAIL: gdb.ada/access_to_packed_array.exp: set logging enabled on (timeout)
FAIL: gdb.ada/access_to_packed_array.exp: maint print symbols (timeout)
FAIL: gdb.base/page-logging.exp: set logging enabled on (timeout)
FAIL: gdb.base/page-logging.exp: printf without paging (timeout)
FAIL: gdb.base/trace-commands.exp: nested trace-commands test (pattern 2)
FAIL: gdb.base/trace-commands.exp: depth resets on error part 1 (pattern 2)
FAIL: gdb.base/ui-redirect.exp: redirect: set logging enabled on (timeout)
FAIL: gdb.base/ui-redirect.exp: redirect: save breakpoints cmds.txt (timeout)
FAIL: gdb.base/ui-redirect.exp: redirect: userdefined (timeout)
FAIL: gdb.base/ui-redirect.exp: redirect logging and debuging: set logging enabled on (timeout)
FAIL: gdb.python/tui-window-factory.exp: msg_3: check for python output
FAIL: gdb.threads/threadapply.exp: thread_set=all: try remove: define remove (timeout)
FAIL: gdb.threads/threadapply.exp: thread_set=all: try remove 2: define remove-again (timeout)
FAIL: gdb.tui/basic.exp: scroll up
FAIL: gdb.tui/basic.exp: check main is where we expect on the screen
FAIL: gdb.tui/basic.exp: scroll right
FAIL: gdb.tui/basic.exp: scroll down
FAIL: gdb.tui/basic.exp: asm window shows main
FAIL: gdb.tui/completion.exp: check focus completions
FAIL: gdb.tui/info-win.exp: info win, layout src
FAIL: gdb.tui/info-win.exp: info win, layout h
FAIL: gdb.tui/new-layout.exp: layout=cmd_only {cmd 1} {} {}: info win output
FAIL: gdb.tui/scroll.exp: check cmd window
FAIL: gdb.tui/scroll.exp: check cmd window in flip layout
FAIL: gdb.tui/tui-focus.exp: check test2 focus message
FAIL: gdb.tui/tui-focus.exp: check ambiguous focus message
FAIL: gdb.tui/tui-layout-asm.exp: scroll to end of assembler (scroll failed)
FAIL: gdb.tui/tui-nl-filtered-output.exp: check printf output
FAIL: gdb.tui/winheight.exp: check error message about src size 100
FAIL: gdb.tui/winheight.exp: check error message about src +1
...

Related PRs:
- PR22454 - "logging sometimes prints prompt"
- PR30288 - "[gdb/cli, editing off] FAIL: gdb.base/trace-commands.exp: nested
  trace-commands test (pattern 2)"
Comment 1 Tom de Vries 2023-03-30 11:06:11 UTC
The tentative patch at PR30290 - "[gdb/tui] tui unusable with editing off" fixes a fair amount of the tui test-case fails.

But it doesn't cover the ones that use readline bindings (arrow up etc), and also the output is not as expected for tui test-cases using python, haven't looked into that.

Anyway, I think the fails fall into 3 categories:
- sending more than one command to gdb at a time
- tui
- gdb prompt put into log file instead of stdout

I was actually looking for instances of a 4th category: tab completion, but AFAICT those have all been fixed.