Bug 30253 - [gdb] FAIL: gdb.gdb/python-helper.exp: pretty print type->main_type
Summary: [gdb] FAIL: gdb.gdb/python-helper.exp: pretty print type->main_type
Status: RESOLVED FIXED
Alias: None
Product: gdb
Classification: Unclassified
Component: gdb (show other bugs)
Version: HEAD
: P2 normal
Target Milestone: 14.1
Assignee: Tom Tromey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-03-20 16:04 UTC by Tom de Vries
Modified: 2023-03-20 17:41 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom de Vries 2023-03-20 16:04:43 UTC 
I'm getting:
...
(outer-gdb) PASS: gdb.gdb/python-helper.exp: pretty print type
print *val->m_type->main_type^M
$2 = ^M
{name = 0x2bd7980 "int",^M
 code = TYPE_CODE_INT,^M
 flags = [],^M
 owner = 0x2bd6de0 (gdbarch),^M
 target_type = 0x0,^M
 int_stuff = { bit_size = 32, bit_offset = 0 }}^M
(outer-gdb) FAIL: gdb.gdb/python-helper.exp: pretty print type->main_type
...

Test-case expects:
...
    set answer [multi_line \
                    "$decimal = " \
                    "{name = $hex \"int\"," \
                    " code = TYPE_CODE_INT," \
                    " flags = \[^\r\n\]+," \
                    " owner = $hex \\(gdbarch\\)," \
                    " target_type = 0x0," \
                    " type_specific_field = TYPE_SPECIFIC_NONE}"]
    gdb_test -prompt $outer_prompt_re "print *val->m_type->main_type" $answer "pretty print type->main_type"
...
Comment 2 Sourceware Commits 2023-03-20 17:41:01 UTC 
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=505ca0bfa52845fb7793b9f2a808c7c5aa4677fd

commit 505ca0bfa52845fb7793b9f2a808c7c5aa4677fd
Author: Tom Tromey <tromey@adacore.com>
Date:   Mon Mar 20 10:18:22 2023 -0600

    Update python-helper.exp for type allocation changes
    
    The type allocation changes introduced a failure in python-helper.exp
    that I did not notice.  The bug is that, with these patches,
    arch-allocated integer types have a TYPE_SPECIFIC_INT object attached.
    This patch updates the test to allow this.
    
    Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=30253
Comment 3 Tom Tromey 2023-03-20 17:41:48 UTC 
Fixed.