Created attachment 14509 [details] PoC # Reproduce ```bash cd binutils-gdb git reset --hard f2f58a399cf3f946983398cdfe52d0eaa72bf877 mkdir build && cd build ../configure --disable-gdb --disable-gdbserver --disable-gdbsupport --disable-libdecnumber --disable-readline --disable-sim --disable-libbacktrace --disable-gas --disable-ld --disable-werror --enable-targets=all CPPFLAGS=-DDEBUG CFLAGS="-g -O0 -fsanitize=address" make all-binutils MAKEINFO=true && true binutils/addr2line -e poc.bin 0 ``` # Output ``` binutils/addr2line: unknown source command 0 binutils/addr2line: unknown source command 0 binutils/addr2line: unknown source command 0 binutils/addr2line: unknown source command 8 binutils/addr2line: unknown source command 130 ================================================================= ==178354==ERROR: AddressSanitizer: heap-buffer-overflow on address 0x61a000000b80 at pc 0x562eac5f24fc bp 0x7ffd5773ede0 sp 0x7ffd5773edd0 READ of size 1 at 0x61a000000b80 thread T0 #0 0x562eac5f24fb in bfd_getl32 ../../bfd/libbfd.c:728 #1 0x562eacbb1bcb in parse_module ../../bfd/vms-alpha.c:4527 #2 0x562eacbb2fad in module_find_nearest_line ../../bfd/vms-alpha.c:4902 #3 0x562eacbb3911 in _bfd_vms_find_nearest_line ../../bfd/vms-alpha.c:4982 #4 0x562eac5dfb1e in find_address_in_section ../../binutils/addr2line.c:197 #5 0x562eac5faf43 in bfd_map_over_sections ../../bfd/section.c:1366 #6 0x562eac5e08eb in translate_addresses ../../binutils/addr2line.c:337 #7 0x562eac5e0fbc in process_file ../../binutils/addr2line.c:470 #8 0x562eac5e15b1 in main ../../binutils/addr2line.c:579 #9 0x7fdb3ed4bd8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58 #10 0x7fdb3ed4be3f in __libc_start_main_impl ../csu/libc-start.c:392 #11 0x562eac5df244 in _start (/binutils-gdb/build/binutils/addr2line+0x343244) 0x61a000000b80 is located 0 bytes to the right of 1280-byte region [0x61a000000680,0x61a000000b80) allocated by thread T0 here: #0 0x7fdb3effe867 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145 #1 0x562eac5f18d5 in bfd_malloc ../../bfd/libbfd.c:289 #2 0x562eacb9c13a in _bfd_malloc_and_read ../../bfd/libbfd.h:970 #3 0x562eacbb2f77 in module_find_nearest_line ../../bfd/vms-alpha.c:4896 #4 0x562eacbb3911 in _bfd_vms_find_nearest_line ../../bfd/vms-alpha.c:4982 #5 0x562eac5dfb1e in find_address_in_section ../../binutils/addr2line.c:197 #6 0x562eac5faf43 in bfd_map_over_sections ../../bfd/section.c:1366 #7 0x562eac5e08eb in translate_addresses ../../binutils/addr2line.c:337 #8 0x562eac5e0fbc in process_file ../../binutils/addr2line.c:470 #9 0x562eac5e15b1 in main ../../binutils/addr2line.c:579 #10 0x7fdb3ed4bd8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58 SUMMARY: AddressSanitizer: heap-buffer-overflow ../../bfd/libbfd.c:728 in bfd_getl32 Shadow bytes around the buggy address: 0x0c347fff8120: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0c347fff8130: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0c347fff8140: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0c347fff8150: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0x0c347fff8160: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 =>0x0c347fff8170:[fa]fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c347fff8180: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c347fff8190: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c347fff81a0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c347fff81b0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa 0x0c347fff81c0: fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa fa Shadow byte legend (one shadow byte represents 8 application bytes): Addressable: 00 Partially addressable: 01 02 03 04 05 06 07 Heap left redzone: fa Freed heap region: fd Stack left redzone: f1 Stack mid redzone: f2 Stack right redzone: f3 Stack after return: f5 Stack use after scope: f8 Global redzone: f9 Global init order: f6 Poisoned by user: f7 Container overflow: fc Array cookie: ac Intra object redzone: bb ASan internal: fe Left alloca redzone: ca Right alloca redzone: cb Shadow gap: cc ==178354==ABORTING Aborted (core dumped) ``` # Analysis `src_ptr + DST_S_L_SRC_UNSLONG` is accessed without bound check.
The master branch has been updated by Alan Modra <amodra@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=77c225bdeb410cf60da804879ad41622f5f1aa44 commit 77c225bdeb410cf60da804879ad41622f5f1aa44 Author: Alan Modra <amodra@gmail.com> Date: Mon Dec 12 18:28:49 2022 +1030 Lack of bounds checking in vms-alpha.c parse_module PR 29873 PR 29874 PR 29875 PR 29876 PR 29877 PR 29878 PR 29879 PR 29880 PR 29881 PR 29882 PR 29883 PR 29884 PR 29885 PR 29886 PR 29887 PR 29888 PR 29889 PR 29890 PR 29891 * vms-alpha.c (parse_module): Make length param bfd_size_type. Delete length == -1 checks. Sanity check record_length. Sanity check DST__K_MODBEG, DST__K_RTNBEG, DST__K_RTNEND lengths. Sanity check DST__K_SOURCE and DST__K_LINE_NUM elements before accessing. (build_module_list): Pass dst_section size to parse_module.
.