seen with trunk 20221101 on arm-linux-gnueabihf, these tests fail compared to the 2.39 branch: W: [ld-arm/arm-elf.exp] REGRESSION (PASS -> FAIL): ld-arm/attr-merge-wchar-24 W: [ld-arm/arm-elf.exp] REGRESSION (PASS -> FAIL): ld-arm/attr-merge-wchar-42 W: [ld-arm/arm-elf.exp] REGRESSION (PASS -> FAIL): STM32L4XX erratum : LDM cannot be patched when LDM is too far from veneer section
Confirmed. I bisected this to: commit 8cb6e17571f3fb66ccd4fa19f881602542cd06fc Author: Andrew Burgess <aburgess@redhat.com> Date: Fri Sep 2 18:15:30 2022 +0100 opcodes/arm: use '@' consistently for the comment character
Andrew, can you have a look?
Actually the fix is simple, I'll send a (testsuite-only) patch.
Fixed by https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=7eb96b2f0359aa8cc1134fc6af4865f59e71d884 (git commit 7eb96b2f0359aa8cc1134fc6af4865f59e71d884)
The master branch has been updated by Christophe Lyon <clyon@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=7eb96b2f0359aa8cc1134fc6af4865f59e71d884 commit 7eb96b2f0359aa8cc1134fc6af4865f59e71d884 Author: Christophe Lyon <christophe.lyon@arm.com> Date: Wed Nov 2 16:50:15 2022 +0000 arm: PR 29739 Fix typo where ';' should not have been replaced with '@' ';' does not always indicate the start of a comment, and commit 8cb6e17571f3fb66ccd4fa19f881602542cd06fc incorrectly replaced 3 instances of ';' with '@' in expected diagnostics, leading to tests failures. This patch restores the original ';' as needed in these testcases. Fixes bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29739