Bug 29047 - abidiff statistics omit symbol with no debug info changes
Summary: abidiff statistics omit symbol with no debug info changes
Status: UNCONFIRMED
Alias: None
Product: libabigail
Classification: Unclassified
Component: default (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Dodji Seketeli
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-04-11 15:43 UTC by gprocida
Modified: 2022-06-02 15:00 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description gprocida 2022-04-11 15:43:20 UTC
From a recent report:

Leaf changes summary: 510 artifacts changed
Changed leaf types summary: 0 leaf type changed
Removed/Changed/Added functions summary: 0 Removed, 0 Changed, 499 Added functions
Removed/Changed/Added variables summary: 0 Removed, 0 Changed, 11 Added variables
Function symbols changes summary: 0 Removed, 0 Added function symbol not referenced by debug info
Variable symbols changes summary: 0 Removed, 3 Added variable symbols not referenced by debug info

510 = 499 + 11
but should be
513 = 499 + 11 + 3
Comment 1 Dodji Seketeli 2022-06-01 16:20:42 UTC
gprocida at google dot com via Libabigail <libabigail@sourceware.org> a
écrit:

> Leaf changes summary: 510 artifacts changed
> Changed leaf types summary: 0 leaf type changed
> Removed/Changed/Added functions summary: 0 Removed, 0 Changed, 499 Added
> functions
> Removed/Changed/Added variables summary: 0 Removed, 0 Changed, 11 Added
> variables
> Function symbols changes summary: 0 Removed, 0 Added function symbol not
> referenced by debug info
> Variable symbols changes summary: 0 Removed, 3 Added variable symbols not
> referenced by debug info
>
> 510 = 499 + 11
> but should be
> 513 = 499 + 11 + 3

Thank you for reporting this issue.

I posted a patch for this to
https://sourceware.org/pipermail/libabigail/2022q2/004385.html.

Do you see an improvement with that patch at all?

Thanks!
Comment 2 gprocida 2022-06-02 08:48:11 UTC
The patch is good. Thank you.
Comment 3 Dodji Seketeli 2022-06-02 15:00:19 UTC
Hello,

gprocida at google dot com via Libabigail <libabigail@sourceware.org> a
écrit:

> https://sourceware.org/bugzilla/show_bug.cgi?id=29047
>
> --- Comment #2 from gprocida at google dot com ---
> The patch is good. Thank you.

[...]

Dodji Seketeli <dodji@seketeli.org> a écrit:

>
> 	* src/abg-comparison.cc (corpus_diff::priv::emit_diff_stats): In
> 	the "leaf change summary" section, add the number of removed/added
> 	symbols not described by debug info.
>
> Signed-off-by: Dodji Seketeli <dodji@redhat.com>

Applied to master, thanks!

[...]

Cheers,