Bug 28695 - Linker doesn't warn p_align < sh_addralign
Summary: Linker doesn't warn p_align < sh_addralign
Status: RESOLVED FIXED
Alias: None
Product: binutils
Classification: Unclassified
Component: ld (show other bugs)
Version: 2.38
: P2 normal
Target Milestone: 2.38
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-12-14 14:22 UTC by H.J. Lu
Modified: 2022-01-05 13:32 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description H.J. Lu 2021-12-14 14:22:05 UTC
[hjl@gnu-cfl-2 align-1]$ cat load.c
#include <stdio.h>
#include <stdint.h>
#include <stdlib.h>

#define ALIGN 0x200000

int
__attribute__ ((weak))
is_aligned (void *p, int align)
{
  return (((uintptr_t) p) & (align - 1)) != 0;
}

int foo __attribute__ ((aligned (ALIGN))) = 1;

int
main (void)
{
  printf ("foo: %p\n", &foo);
  if (is_aligned (&foo, ALIGN))
    abort ();
  return 0;
}
[hjl@gnu-cfl-2 align-1]$ make
gcc -O2 -fPIE   -c -o load.o load.c
gcc -pie -Wl,-z,max-page-size=0x1000 -O2 -fPIE -o pie load.o
readelf -SW load.o | grep "\.data"
  [ 2] .data             PROGBITS        0000000000000000 200000 000004 00  WA  0   0 2097152
readelf -lW pie | grep LOAD
  LOAD           0x000000 0x0000000000000000 0x0000000000000000 0x0006a8 0x0006a8 R   0x1000
  LOAD           0x001000 0x0000000000001000 0x0000000000001000 0x0001bd 0x0001bd R E 0x1000
  LOAD           0x002000 0x0000000000002000 0x0000000000002000 0x00010c 0x00010c R   0x1000
  LOAD           0x002de0 0x0000000000003de0 0x0000000000003de0 0x000248 0x000248 RW  0x1000
  LOAD           0x200000 0x0000000000200000 0x0000000000200000 0x200004 0x200008 RW  0x1000
./pie
foo: 0x7f9fcb0fa000
make: *** [Makefile:9: all] Aborted (core dumped)
[hjl@gnu-cfl-2 align-1]$
Comment 1 Sourceware Commits 2022-01-05 13:11:30 UTC
The master branch has been updated by H.J. Lu <hjl@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=74e315dbfe5200c473b226e937935fb8ce391489

commit 74e315dbfe5200c473b226e937935fb8ce391489
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Mon Dec 13 19:46:04 2021 -0800

    elf: Set p_align to the minimum page size if possible
    
    Currently, on 32-bit and 64-bit ARM, it seems that ld generates p_align
    values of 0x10000 even if no section alignment is greater than 0x1000.
    The issue is more general and probably affects other targets with multiple
    page sizes.
    
    While file layout absolutely must take 64K page size into account, that
    does not have to be reflected in the p_align value.  If running on a 64K
    kernel, the file will be loaded at a 64K page boundary by necessity. On
    a 4K kernel, 64K alignment is not needed.
    
    The glibc loader has been fixed to honor p_align:
    
    https://sourceware.org/bugzilla/show_bug.cgi?id=28676
    
    similar to kernel:
    
    commit ce81bb256a224259ab686742a6284930cbe4f1fa
    Author: Chris Kennelly <ckennelly@google.com>
    Date:   Thu Oct 15 20:12:32 2020 -0700
    
        fs/binfmt_elf: use PT_LOAD p_align values for suitable start address
    
    This means that on 4K kernels, we will start to do extra work for 64K
    p_align, but this pointless for pretty much all binaries (whose section
    alignment rarely exceeds 16).
    
    The minimum page size is used, instead of the maximum section alignment
    due to this glibc bug:
    
    https://sourceware.org/bugzilla/show_bug.cgi?id=28688
    
    It has been fixed in glibc 2.35.  But linker output must work on existing
    glibc binaries.
    
    1. Set p_align to the minimum page size while laying out segments aligning
    to the maximum page size or section alignment.  The run-time loader can
    align segments to the minimum page size or above, depending on system page
    size.
    2. If -z max-page-size=NNN is used, p_align will be set to the maximum
    page size or the largest section alignment.
    3. If a section requires alignment higher than the minimum page size,
    don't set p_align to the minimum page size.
    4. If a section requires alignment higher than the maximum page size,
    set p_align to the section alignment.
    5. For objcopy, when the minimum page size != the maximum page size,
    p_align may be set to the minimum page size while segments are aligned
    to the maximum page size.  In this case, the input p_align will be
    ignored and the maximum page size will be used to align the ouput
    segments.
    6. Update linker to disallow the common page size > the maximum page size.
    7. Update linker to avoid the common page size > the maximum page size.
    8. Adjust pru_irq_map-1.d to expect p_align == sh_addralign:
    
    Section Headers:
      [Nr] Name   Type            Addr     Off    Size   ES Flg Lk Inf Al
      [ 0]        NULL            00000000 000000 000000 00      0   0  0
      [ 1] .text  PROGBITS        20000000 00007c 000004 00  AX  0   0  4
    ...
    Program Headers:
      Type           Offset   VirtAddr   PhysAddr   FileSiz MemSiz  Flg Align
      LOAD           0x000074 0x00000000 0x00000000 0x00008 0x00008 RW  0x1
      LOAD           0x00007c 0x20000000 0x20000000 0x00004 0x00004 R E 0x4
    
    vs.
    
    Section Headers:
      [Nr] Name   Type            Addr     Off    Size   ES Flg Lk Inf Al
      [ 0]        NULL            00000000 000000 000000 00      0   0  0
      [ 1] .text  PROGBITS        20000000 00007c 000004 00  AX  0   0  4
    ...
    Program Headers:
      Type           Offset   VirtAddr   PhysAddr   FileSiz MemSiz  Flg Align
      LOAD           0x000074 0x00000000 0x00000000 0x00008 0x00008 RW  0x1
      LOAD           0x00007c 0x20000000 0x20000000 0x00004 0x00004 R E 0x1
    
    To enable this linker optimization, the backend should define ELF_P_ALIGN
    to ELF_MINPAGESIZE.
    
    bfd/
    
            PR ld/28689
            PR ld/28695
            * elf-bfd.h (elf_backend_data): Add p_align.
            * elf.c (assign_file_positions_for_load_sections): Set p_align
            to the default p_align value while laying out segments aligning
            to maximum page size or section alignment.
            (elf_is_p_align_valid): New function.
            (copy_elf_program_header): Call elf_is_p_align_valid to determine
            if p_align is valid.
            * elfxx-target.h (ELF_P_ALIGN): New.  Default to 0.
            (elfNN_bed): Add ELF_P_ALIGN.
            * elfxx-x86.h (ELF_P_ALIGN): New.  Set to ELF_MINPAGESIZE.
    
    include/
    
            PR ld/28689
            PR ld/28695
            * bfdlink.h (bfd_link_info): Add maxpagesize_is_set.
    
    ld/
    
            PR ld/28689
            PR ld/28695
            * emultempl/elf.em (gld${EMULATION_NAME}_handle_option): Set
            link_info.maxpagesize_is_set for -z max-page-size=NNN.
            * ldelf.c (ldelf_after_parse): Disallow link_info.commonpagesize
            > link_info.maxpagesize.
            * testsuite/ld-elf/elf.exp: Pass -z max-page-size=0x4000 to
            linker to build mbind2a and mbind2b.
            * testsuite/ld-elf/header.d: Add -z common-page-size=0x100.
            * testsuite/ld-elf/linux-x86.exp: Add PR ld/28689 tests.
            * testsuite/ld-elf/p_align-1.c: New file.
            * testsuite/ld-elf/page-size-1.d: New test.
            * testsuite/ld-elf/pr26936.d: Add -z common-page-size=0x1000.
            * testsuite/ld-elf/seg.d: Likewise.
            * testsuite/ld-scripts/rgn-at5.d: Likewise.
            * testsuite/ld-pru/pru_irq_map-1.d: Append 1 to name.  Adjust
            expected PT_LOAD segment alignment.
            * testsuite/ld-pru/pru_irq_map-2.d: Append 2 to name.
            * testsuite/ld-scripts/pr23571.d: Add -z max-page-size=0x1000.
Comment 2 H.J. Lu 2022-01-05 13:32:15 UTC
Fixed in binutils 2.38.  ld will set the proper p_align.  Also need the
glibc fix: PR 28676.