Bug 27781 - Please add the new rif_MA locale
Summary: Please add the new rif_MA locale
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: localedata (show other bugs)
Version: unspecified
: P2 enhancement
Target Milestone: ---
Assignee: Mike FABIAN
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-27 15:09 UTC by Ilyahoo Proshel
Modified: 2022-04-07 13:43 UTC (History)
5 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed: 2021-11-12 00:00:00


Attachments
rif_MA locale file (1.66 KB, text/plain)
2021-04-27 15:09 UTC, Ilyahoo Proshel
Details
rif_MA updated locale file (1.99 KB, text/plain)
2021-08-17 17:11 UTC, Ilyahoo Proshel
Details
updated rif_MA locale (1.41 KB, text/plain)
2022-01-22 18:35 UTC, Ilyahoo Proshel
Details
test input for rif_MA (132 bytes, application/octet-stream)
2022-01-22 18:35 UTC, Ilyahoo Proshel
Details
Slighly improved rif_MA (1.28 KB, text/plain)
2022-04-06 06:10 UTC, Mike FABIAN
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ilyahoo Proshel 2021-04-27 15:09:08 UTC
Created attachment 13401 [details]
rif_MA locale file

Dear maintainers,

Please find attached the locale definition for "Tarifit language locale for Morocco" to be considered for inclusion in glibc.

Thanks!
Comment 1 Ilyahoo Proshel 2021-08-17 17:11:34 UTC
Created attachment 13620 [details]
rif_MA updated locale file

We update the names and text in the locale file
Comment 2 Carlos O'Donell 2021-11-12 21:28:30 UTC
(In reply to Ilyahoo Proshel from comment #1)
> Created attachment 13620 [details]
> rif_MA updated locale file
> 
> We update the names and text in the locale file

This needs to be posted to libc-alpha@sourceware.org for review.

Along with that review it would be good if you could include a test case for Tarifit:

- Add localedata/rif_MA.UTF-8.in with expected sort order for data.
- Add rif_MA.UTF-8 to test-input

This should add rif_MA.UTF-8 testing to glibc to ensure the sorting matches your expectations and stays this way going forward. This prevents accidental breakage in collation when refactoring during ISO 14651 updates.
Comment 3 Ilyahoo Proshel 2022-01-22 18:35:11 UTC
Created attachment 13921 [details]
updated rif_MA locale
Comment 4 Ilyahoo Proshel 2022-01-22 18:35:53 UTC
Created attachment 13922 [details]
test input for rif_MA
Comment 5 Ilyahoo Proshel 2022-01-22 18:36:13 UTC
Dear maintainers,

I added localedata/rif_MA.UTF-8.in the I added rif_MA.UTF-8 to test-input. I modified the original locale to prevent some errors.

make localedata/tests has been done without any errors.

Please find attached files.
Comment 6 Adhemerval Zanella 2022-01-24 11:33:46 UTC
(In reply to Ilyahoo Proshel from comment #5)
> Dear maintainers,
> 
> I added localedata/rif_MA.UTF-8.in the I added rif_MA.UTF-8 to test-input. I
> modified the original locale to prevent some errors.
> 
> make localedata/tests has been done without any errors.
> 
> Please find attached files.

Please send any patch to libc-alpha [1], here are some links on how to contribute [2].  Patches are only reviewed on the maillist.

[1] https://sourceware.org/mailman/listinfo/libc-alpha
[2] https://sourceware.org/glibc/wiki/Contribution%20checklist
Comment 7 Mike FABIAN 2022-04-06 06:10:33 UTC
Created attachment 14051 [details]
Slighly improved rif_MA

I used ASCII characters directly instead of <U...>, for example:

abday           "L<U1E25>e";/
                "Let";/
                "Ttl";/
                "Lar";/
                "Lex";/
                "Jje";/
                "Sbt"

Only for non ASCII characters we are still using the <U....> code point notation, using the ASCII characters directly makes it a lot more readable.

I also added:

lang_name    "Tmazi<U0263>t"

Does that look OK to you?
Comment 8 Ilyahoo Proshel 2022-04-06 11:09:47 UTC
(In reply to Mike FABIAN from comment #7)
> Created attachment 14051 [details]
> Slighly improved rif_MA
> 
> I used ASCII characters directly instead of <U...>, for example:
> 
> abday           "L<U1E25>e";/
>                 "Let";/
>                 "Ttl";/
>                 "Lar";/
>                 "Lex";/
>                 "Jje";/
>                 "Sbt"
> 
> Only for non ASCII characters we are still using the <U....> code point
> notation, using the ASCII characters directly makes it a lot more readable.
> 
> I also added:
> 
> lang_name    "Tmazi<U0263>t"
> 
> Does that look OK to you?

Thank you for you help and your work on improving the locale.
everything seems to be ok. Just the name. it's a locale for "Tarifit", and not "Tmazi<U0263>t". because the last one is another language.

And by the way. we did send the patch for the unmodified locale. and it pass the build successfully, if you want to take a look here:
https://patchwork.sourceware.org/project/glibc/patch/20220125172555.2527278-1-ip@ipshel.com/

Thank you a lot.
Comment 9 Mike FABIAN 2022-04-06 15:54:24 UTC
https://en.wikipedia.org/wiki/Tarifit

The wikipedia article said that the endonym (The name of the language in itself) is Tmaziɣt or Tarifiyt or Tarifect and I did just choose the first one.

According to Wikipedia, “Tarifit” is the name of the language in English.

lang_name should contain the endonym whereas 

language   "Tarifit"

should contain the English name.
Comment 10 Mike FABIAN 2022-04-06 15:56:59 UTC
> And by the way. we did send the patch for the unmodified locale. and it pass
> the build successfully, if you want to take a look here:
> https://patchwork.sourceware.org/project/glibc/patch/20220125172555.2527278-
> 1-ip@ipshel.com/

Yes, I read your mail and the attached patch and I took the
the test input file from the patch in the mail because the one
attached to the bug report here does not work (i.e. sorting the test file
attached to the bug does not reproduce the test input).
Comment 11 Mike FABIAN 2022-04-06 16:03:29 UTC
(In reply to Mike FABIAN from comment #9)
> https://en.wikipedia.org/wiki/Tarifit
> 
> The wikipedia article said that the endonym (The name of the language in
> itself) is Tmaziɣt or Tarifiyt or Tarifect and I did just choose the first
> one.
> 
> According to Wikipedia, “Tarifit” is the name of the language in English.
> 
> lang_name should contain the endonym whereas 
> 
> language   "Tarifit"
> 
> should contain the English name.

Wikipedia> Its own speakers simply call it "Tamazight", a term also often applied Wikipedia> in a broader sense to the Berber language across North Africa in Wikipedia> general.
Comment 12 Ilyahoo Proshel 2022-04-06 16:47:32 UTC
(In reply to Mike FABIAN from comment #11)
> (In reply to Mike FABIAN from comment #9)
> > https://en.wikipedia.org/wiki/Tarifit
> > 
> > The wikipedia article said that the endonym (The name of the language in
> > itself) is Tmaziɣt or Tarifiyt or Tarifect and I did just choose the first
> > one.
> > 
> > According to Wikipedia, “Tarifit” is the name of the language in English.
> > 
> > lang_name should contain the endonym whereas 
> > 
> > language   "Tarifit"
> > 
> > should contain the English name.
> 
> Wikipedia> Its own speakers simply call it "Tamazight", a term also often
> applied Wikipedia> in a broader sense to the Berber language across North
> Africa in Wikipedia> general.

Tamazight is the mother language where multiple other languages inherited from it. Including Tarifit. 
And what’s apply for Tarifit does mean that can apply for another sub-tamazight languages, and vice versa. So we believe that lang_name should be “Tarifit”.

Should we resend the patch by email with your improvements?
Thank you very much for your time.
Comment 13 Mike FABIAN 2022-04-07 08:31:18 UTC
> Tamazight is the mother language where multiple other languages inherited
> from it. Including Tarifit. 
> And what’s apply for Tarifit does mean that can apply for another
> sub-tamazight languages, and vice versa. So we believe that lang_name should
> be “Tarifit”.
> 
> Should we resend the patch by email with your improvements?
> Thank you very much for your time.

No, you don’t need to resend the patch, I just change lang_name to “Tarifit” and then I can commit it, I think.
Comment 14 Sourceware Commits 2022-04-07 13:29:29 UTC
The master branch has been updated by Mike Fabian <mfabian@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=189906b68742e8b26bca7103a7f3c221de36d0fd

commit 189906b68742e8b26bca7103a7f3c221de36d0fd
Author: Ilyahoo Proshel <ip@ipshel.com>
Date:   Tue Apr 5 13:23:16 2022 +0200

    Add rif_MA locale [BZ #27781]
    
    Resolves: BZ #27781
Comment 15 Mike FABIAN 2022-04-07 13:39:21 UTC
Fixed in glibc master.
Comment 16 Ilyahoo Proshel 2022-04-07 13:43:49 UTC
Thank you, We really appreciate your time and your contribution.(In reply to Mike FABIAN from comment #15)
> Fixed in glibc master.