Bug 27742 - FAIL: gdb.opt/inline-locals.exp: info locals above bar 2/3
Summary: FAIL: gdb.opt/inline-locals.exp: info locals above bar 2/3
Status: RESOLVED FIXED
Alias: None
Product: gdb
Classification: Unclassified
Component: gdb (show other bugs)
Version: HEAD
: P2 normal
Target Milestone: 11.1
Assignee: Tom Tromey
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-16 09:16 UTC by Tom de Vries
Modified: 2021-04-19 13:17 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom de Vries 2021-04-16 09:16:13 UTC 
New FAILs:
...
FAIL: gdb.opt/inline-locals.exp: info locals above bar 2
FAIL: gdb.opt/inline-locals.exp: info locals above bar 3
...

First in more detail:
...
(gdb) PASS: gdb.opt/inline-locals.exp: func1 inlined 2
info locals^M
array = {0 <repeats 64 times>}^M
array = <optimized out>^M
(gdb) FAIL: gdb.opt/inline-locals.exp: info locals above bar 2
...
Comment 1 Tom de Vries 2021-04-16 10:44:55 UTC 
Bisects to:
...
commit 644a2e75ace6b5e76f91d38c28c3b97fcfdeeaa5 (HEAD)
Author: Tom Tromey <tromey@adacore.com>
Date:   Thu Apr 15 10:14:11 2021 -0600

    Use common_val_print_checked in print_variable_and_value
...

Before:
...
(gdb) PASS: gdb.opt/inline-locals.exp: func1 inlined 2
info locals^M
array = {0 <repeats 64 times>}^M
array = {<optimized out> <repeats 64 times>}^M
(gdb) KFAIL: gdb.opt/inline-locals.exp: info locals above bar 2 (PRMS: gdb/25695)
...
and after:
...
(gdb) PASS: gdb.opt/inline-locals.exp: func1 inlined 2
info locals^M
array = {0 <repeats 64 times>}^M
array = <optimized out>^M
(gdb) FAIL: gdb.opt/inline-locals.exp: info locals above bar 2
...

Should the KFAIL pattern be updated?
Comment 2 Tom Tromey 2021-04-16 16:40:15 UTC 
Sorry about that.
Comment 3 Tom Tromey 2021-04-16 18:08:55 UTC 
I couldn't reproduce this one.

		=== gdb Summary ===

# of expected passes		22

info locals
array = {0 <repeats 64 times>}


I'm using the x86-64 Fedora 32 system gcc, aka 10.2.
Which compiler are you using?
Comment 4 Tom de Vries 2021-04-16 18:12:56 UTC 
(In reply to Tom Tromey from comment #3)
> I couldn't reproduce this one.
> 
> 		=== gdb Summary ===
> 
> # of expected passes		22
> 
> info locals
> array = {0 <repeats 64 times>}
> 
> 
> I'm using the x86-64 Fedora 32 system gcc, aka 10.2.
> Which compiler are you using?

gcc 7.5.0.  Also reproducible with 8.4.0.
Comment 5 Tom Tromey 2021-04-16 19:23:20 UTC 
I will try to update the kfail based on the text in the bug.
Comment 6 Sourceware Commits 2021-04-19 13:16:46 UTC 
The master branch has been updated by Tom Tromey <tromey@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=392e0bcc0e4088ff6c31ed43a6232e709bf52751

commit 392e0bcc0e4088ff6c31ed43a6232e709bf52751
Author: Tom Tromey <tromey@adacore.com>
Date:   Mon Apr 19 07:16:34 2021 -0600

    Fix kfail patterns in inline-locals.exp
    
    PR gdb/27742 points out that my recent change to
    print_variable_and_value caused a regression in inline-locals.exp.  I
    can't reproduce this, but I came up with this patch based on the
    output shown in the bug.
    
    gdb/testsuite/ChangeLog
    2021-04-19  Tom Tromey  <tromey@adacore.com>
    
            PR gdb/27742:
            * gdb.opt/inline-locals.exp: Update kfail patterns.
Comment 7 Tom Tromey 2021-04-19 13:17:31 UTC 
Fixed.