Bug 27640 - find-debuginfo.sh or find-debuginfo?
Summary: find-debuginfo.sh or find-debuginfo?
Status: RESOLVED FIXED
Alias: None
Product: debugedit
Classification: Unclassified
Component: find-debuginfo (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-24 06:34 UTC by Matthias Klose
Modified: 2021-06-18 07:03 UTC (History)
3 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matthias Klose 2021-03-24 06:34:40 UTC 
How should that be named, find-debuginfo.sh or find-debuginfo?

Usually the interpreter name is not included in the tool name.
Comment 1 Mark Wielaard 2021-05-06 00:33:37 UTC 
It would be nice to rename it to simply find-debuginfo. But this might have some backwards compatibility issues for rpm and old spec files which might rely on the exact name. This might not be too strong an objection to renaming it though. Up till now this was an internal detail of rpm.
Comment 2 Panu Matilainen 2021-05-06 09:52:25 UTC 
Rpm will not mind renaming, but if you want to do it then please do it *now* rather than some future point.

There are quite some packages directly referring %{_rpmconfigdir}/find-debuginfo.sh or /usr/lib/rpm/find-debuginfo.sh, and as the path will now change anyhow, I think rpm needs to setup a symlink pointing to the real script at that location for backwards compat.
Comment 3 Mark Wielaard 2021-05-18 17:26:06 UTC 
find-debuginfo (without .sh) it is (also changed the component name in bugzilla)

commit 75e085aa341c247cdb47d9a40a6324f308ceccae
Author: Mark Wielaard <mark@klomp.org>
Date:   Tue May 18 19:03:31 2021 +0200

    Rename find-debuginfo.sh to find-debuginfo
    
    Even though it is currently a bash script we install it as a normal
    program. So simply install it without the .sh suffix. To get the VERSION
    right in the script make it an AC_CONFIG_FILE (from find-debuginfo.in).
    This also fixes the man page name and version.
    
            * .gitignore: Remove find-debuginfo.sh.1.
            Add scripts/find-debuginfo and find-debuginfo.1
            * configure.ac (AC_CONFIG_FILES): Add scripts/find-debuginfo.
            * Makefile.am (bin_SCRIPTS): Rename find-debuginfo.sh to
            find-debuginfo.
            (dist_man_MANS): Rename find-debuginfo.sh.1 to find-debuginfo.1.
            (find-debuginfo.sh.1): Rename to ...
            (find-debuginfo.1): ...this and update invocation.
            (EXTRA_DIST): Rename scripts/find-debuginfo.sh to
            scripts/find-debuginfo.
            * scripts/find-debuginfo.sh: Rename to ...
            * scripts/find-debuginfo.in: ...this.
            Change all find-debuginfo.sh to find-debuginfo.
            Use @VERSION@ for --version.
    
    Signed-off-by: Mark Wielaard <mark@klomp.org>
Comment 4 Panu Matilainen 2021-06-14 10:26:29 UTC 
Hey, could we have a new release with this change, even if only for that particular purpose? I'd like to proceed from the rpm side, but I really don't want to deal with multiple possible names when it's already decided that it'll be one and not the other.
Comment 5 Dmitry V. Levin 2021-06-14 10:35:02 UTC 
(In reply to Panu Matilainen from comment #4)
> Hey, could we have a new release with this change, even if only for that
> particular purpose?

+1
Comment 6 Mark Wielaard 2021-06-17 16:59:26 UTC 
(In reply to Dmitry V. Levin from comment #5)
> (In reply to Panu Matilainen from comment #4)
> > Hey, could we have a new release with this change, even if only for that
> > particular purpose?
> 
> +1

debugedit 0.3 has been released!
https://sourceware.org/pub/debugedit/0.3/

For Fedora I did a build with a compatibility find-debuginfo.sh -> find-debuginfo symlink for now to not accidentially break anything. But I'll remove that for the next build.
Comment 7 Panu Matilainen 2021-06-18 07:03:57 UTC 
Perfect, thanks!