Bug 27592 - dwz: latest binutils change makes some tests FAIL
Summary: dwz: latest binutils change makes some tests FAIL
Status: RESOLVED FIXED
Alias: None
Product: dwz
Classification: Unclassified
Component: default (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-17 08:17 UTC by Martin Liska
Modified: 2021-03-20 08:38 UTC (History)
3 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Liska 2021-03-17 08:17:43 UTC
After d6bfbc398158eaa381b08c7cf7b943ac4085d4a6:
https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=d6bfbc398158eaa381b08c7cf7b943ac4085d4a6

dwz testsuite fails with:
[   57s] FAIL: /home/abuild/rpmbuild/BUILD/dwz/testsuite/dwz.tests/eu-strip-unstrip-multifile.sh
[   57s] readelf: Warning: Section '.gnu_debugaltlink' in linked file '4' was not dumped because it does not exist
[   57s] readelf: Warning: Section '.gnu_debugaltlink' in linked file '4' was not dumped because it does not exist
[   57s] FAIL: /home/abuild/rpmbuild/BUILD/dwz/testsuite/dwz.tests/hardlink-multifile.sh
[   58s] readelf: Warning: Section '.gnu_debugaltlink' in linked file '3' was not dumped because it does not exist
[   58s] readelf: Warning: Section '.gnu_debugaltlink' in linked file '3' was not dumped because it does not exist
[   58s] FAIL: /home/abuild/rpmbuild/BUILD/dwz/testsuite/dwz.tests/ld-2.26.1-multifile.sh
[   58s] readelf: Warning: Section '.gnu_debugaltlink' in linked file '3' was not dumped because it does not exist
[   58s] readelf: Warning: Section '.gnu_debugaltlink' in linked file '3' was not dumped because it does not exist
[   58s] FAIL: /home/abuild/rpmbuild/BUILD/dwz/testsuite/dwz.tests/multifile-relative.sh
[   59s] readelf: Warning: Section '.gnu_debugaltlink' in linked file '3' was not dumped because it does not exist
[   59s] readelf: Warning: Section '.gnu_debugaltlink' in linked file '3' was not dumped because it does not exist
[   59s] FAIL: /home/abuild/rpmbuild/BUILD/dwz/testsuite/dwz.tests/multifile.sh

which can be easily reproduced with:
$ g++ ./testsuite/dwz.tests/odr.cc ./testsuite/dwz.tests/odr-2.cc -DKIND=struct -g -o 1
$ cp 1 2
$ dwz --odr 1 2 -m 3
$ readelf --string-dump=.gnu_debugaltlink 1

String dump of section '.gnu_debugaltlink':
  [     0]  3
.......
readelf: Warning: Section '.gnu_debugaltlink' in linked file '3' was not dumped because it does not exist

while before the revision, there was no such a warning.
Comment 1 Tom de Vries 2021-03-17 09:16:51 UTC
Yeah, this looks like a duplicate of PR27478, just with a differently formulated warning.
Comment 2 Martin Liska 2021-03-17 09:19:47 UTC
(In reply to Tom de Vries from comment #1)
> Yeah, this looks like a duplicate of PR27478, just with a differently
> formulated warning.

Are we sure? I mean the mentioned PR is fixed with a commit ca0e11aa4ba877e180f7d40dcc5a89540740c501 (Date:   Thu Mar 4 10:41:22 2021 +0000), but I bisected that to a commit that was pushed yesterday.
Comment 3 Tom de Vries 2021-03-17 10:36:37 UTC
(In reply to Martin Liska from comment #2)
> (In reply to Tom de Vries from comment #1)
> > Yeah, this looks like a duplicate of PR27478, just with a differently
> > formulated warning.
> 
> Are we sure? I mean the mentioned PR is fixed with a commit
> ca0e11aa4ba877e180f7d40dcc5a89540740c501 (Date:   Thu Mar 4 10:41:22 2021
> +0000), but I bisected that to a commit that was pushed yesterday.

Well, the test-case is identical.  So AFAIU this was fixed for a while and now regressed again.  In other words, if we mark this as duplicate of PR27478, we need to reopen PR27478.
Comment 4 Martin Liska 2021-03-17 11:03:02 UTC
> In other words, if we mark this as duplicate of
> PR27478, we need to reopen PR27478.

I would do that then.
Comment 5 Tom de Vries 2021-03-18 10:40:51 UTC
(In reply to Martin Liska from comment #4)
> > In other words, if we mark this as duplicate of
> > PR27478, we need to reopen PR27478.
> 
> I would do that then.

I've tentatively reopened that PR.  Let's see if that gets confirmed.
Comment 6 Tom de Vries 2021-03-18 16:02:39 UTC
Ok, that PR got re-fixed.

Now we have instead:
...
FAIL: testsuite/dwz.tests/odr-struct-multifile.sh
...
Comment 7 Tom de Vries 2021-03-20 08:38:48 UTC
Fixed by testsuite update: https://sourceware.org/git/?p=dwz.git;a=commit;h=b1f26dc76158e1f3364836d8b540b17a7a1ccb3d