Bug 26565 - Support specifying --header-dir{1,2} several times on the command line of abidiff
Summary: Support specifying --header-dir{1,2} several times on the command line of abi...
Status: RESOLVED FIXED
Alias: None
Product: libabigail
Classification: Unclassified
Component: default (show other bugs)
Version: unspecified
: P2 enhancement
Target Milestone: ---
Assignee: Dodji Seketeli
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-09-02 06:50 UTC by Dodji Seketeli
Modified: 2020-09-18 15:09 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dodji Seketeli 2020-09-02 06:50:37 UTC 
Sometimes, a binary (shared binary for instance) might come with its header files spread over several directories.  In that case we must be able to let abidiff know about all the header files directories by specifying the --headers-dir1 (or --headers-dir2) several times on the command line, just like what can be done with --debug-info-dir{1,2}.

The same thing must be supported for the --headers-dir option of abidw.
Comment 1 Dodji Seketeli 2020-09-02 07:03:58 UTC 
There is code in the branch https://sourceware.org/git/?p=libabigail.git;a=shortlog;h=refs/heads/dodji/mult-headers to support this.

That is, one can specify --headers-dir{1,2} several times on the command line of abidiff and it should do the right thing.

I guess this needs some more testing before it can be folded into master.
Comment 2 Dodji Seketeli 2020-09-18 14:39:09 UTC 
This feature landed in the master branch of the git repository at https://sourceware.org/git/?p=libabigail.git;a=commit;h=ee2b54ddd9eb79297e90dd4252dc5c672073c9fc and should be available in the 1.8 version of libabigail.
Comment 3 David Cantrell 2020-09-18 15:09:44 UTC 
Thank you!  This is a great addition to abidiff.