Bug 25491 - binutils 2.34 tarball requires makeinfo
Summary: binutils 2.34 tarball requires makeinfo
Status: RESOLVED FIXED
Alias: None
Product: binutils
Classification: Unclassified
Component: binutils (show other bugs)
Version: 2.34
: P2 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
: 25644 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-02-01 19:48 UTC by Marius Bakke
Modified: 2023-02-21 10:04 UTC (History)
6 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed: 2020-03-06 00:00:00

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marius Bakke 2020-02-01 19:48:17 UTC 
Hello,

The binutils 2.34 release tarballs are missing the pre-generated manuals, causing a build failure if "makeinfo" is unavailable:

/tmp/guix-build-binutils-2.34.drv-0/binutils-2.34/missing: line 81: makeinfo: command not found
WARNING: 'makeinfo' is missing on your system.
         You should only need it if you modified a '.texi' file, or
         any other file indirectly affecting the aspect of the manual.
         You might want to install the Texinfo package:
         <http://www.gnu.org/software/texinfo/>
         The spurious makeinfo call might also be the consequence of
         using a buggy 'make' (AIX, DU, IRIX), in which case you might
         want to install GNU make:
         <http://www.gnu.org/software/make/>
make[3]: *** [Makefile:474: binutils.info] Error 127
make[3]: Leaving directory '/tmp/guix-build-binutils-2.34.drv-0/binutils-2.34/binutils/doc'
Comment 1 Michael Forney 2020-02-01 22:35:14 UTC 
I ran into this as well. I think it is caused by this commit:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commitdiff;h=2b44a6a237320a390284b1a8237a6bed67d5401f;hp=89ae5e692398f008d06a8e38d1b531131f41a683

It doesn't seem like removal of the pre-generated binutils.info was intended.
Comment 2 Simon Marchi 2020-03-06 14:55:29 UTC 
Oh, so anything requiring makeinfo should not be cleaned with `clean`, but with `maintainer-clean`?  It seems like my patch should be reverted then.
Comment 3 Simon Marchi 2020-03-06 16:26:56 UTC 
Patch posted here: https://www.sourceware.org/ml/binutils/2020-03/msg00156.html
Comment 4 Sourceware Commits 2020-03-07 03:07:56 UTC 
The master branch has been updated by Simon Marchi <simark@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=9979ab666354f355da46ba826a3efeef9fbb8b24

commit 9979ab666354f355da46ba826a3efeef9fbb8b24
Author: Simon Marchi <simon.marchi@efficios.com>
Date:   Fri Mar 6 22:06:34 2020 -0500

    binutils: doc: move artifacts back to MAINTAINERCLEANFILES
    
    In commit 2b44a6a237 (" binutils: doc: make `make clean` clean more
    things"), I moved the doc build artifacts to MOSTLYCLEANFILES, which
    made them get removed by "make clean".
    
    Because generating binutils.info requires makeinfo, and we do not want
    to require makeinfo when building from the tarball, binutils.info should
    not get removed by "make clean" (otherwise, it won't be included in the
    tarball).
    
    And to be consistent with other projects (e.g. ld and gas), we also want
    to ship the built man pages in the tarball.
    
    This patch puts back all these in MAINTAINERCLEANFILES, so that they are
    bundled in the tarball, and only cleaned if you use "make
    maintainer-clean".
    
    Tested by building a source release and confirming they are present.
    
    binutils/ChangeLog:
    
    	PR 25491
    	* doc/Makefile.am: Rename MOSTLYCLEANFILES to MAINTAINERCLEANFILES.
    	* doc/Makefile.in: Re-generate.
Comment 5 Simon Marchi 2020-03-07 03:10:11 UTC 
Fixed by patch mentioned above.
Comment 6 Andreas Schwab 2020-03-08 15:01:45 UTC 
*** Bug 25644 has been marked as a duplicate of this bug. ***