Bug 25284 - Disallow .align .p2align .balign without operands
Summary: Disallow .align .p2align .balign without operands
Status: RESOLVED FIXED
Alias: None
Product: binutils
Classification: Unclassified
Component: gas (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-12-15 22:08 UTC by Fangrui Song
Modified: 2020-01-08 17:05 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fangrui Song 2019-12-15 22:08:44 UTC 
These directives are allowed without an operand.

.balign
.align
.p2align

Such forms should probably be removed.
Comment 1 Sourceware Commits 2020-01-08 17:02:46 UTC 
The master branch has been updated by Nick Clifton <nickc@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=915808f652b63746052b1ef59403650b45a30e4f

commit 915808f652b63746052b1ef59403650b45a30e4f
Author: Nick Clifton <nickc@redhat.com>
Date:   Wed Jan 8 17:00:54 2020 +0000

    Document the fact that the assembler's alignment pseudo-ops can be issued without any argumemtns.
    
    	PR 25284
    	* doc/as.texi (Align): Document the fact that all arguments can be
    	omitted.
    	(Balign): Likewise.
    	(P2align): Likewise.
Comment 2 Nick Clifton 2020-01-08 17:05:44 UTC 
Hi Ray,

  I prefer not to change the assembler's behaviour in a situation like this, so instead I have documented what happens.

Cheers
  Nick