Bug 25139 - Please add the new mnw_MM locale
Summary: Please add the new mnw_MM locale
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: localedata (show other bugs)
Version: unspecified
: P2 enhancement
Target Milestone: 2.31
Assignee: Mike FABIAN
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-10-28 08:00 UTC by talachan
Modified: 2020-01-10 16:00 UTC (History)
8 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed: 2019-11-12 00:00:00
fweimer: security-


Attachments
mnw_MM that is the Mon language locale for Myanmar (deleted)
2019-10-28 08:00 UTC, talachan
Details
Dear maintainers, Please find attached the locale definition for <locale> to be considered for inclusion in glibc. (2.46 KB, text/plain)
2019-10-28 08:05 UTC, talachan
Details
mnw_MM slighly changed (2.40 KB, text/plain)
2019-11-05 10:38 UTC, Mike FABIAN
Details
fix group and other (640 bytes, patch)
2019-11-05 14:01 UTC, kokoye2007
Details | Diff
mnw_MM (2.42 KB, text/plain)
2019-11-05 18:12 UTC, kokoye2007
Details
mnw_MM fix groups error message (637 bytes, patch)
2019-11-05 18:13 UTC, kokoye2007
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description talachan 2019-10-28 08:00:48 UTC
Dear maintainers,

Please find attached the locale definition for <locale> to be
considered for inclusion in glibc.
Comment 1 talachan 2019-10-28 08:05:47 UTC
Created attachment 12055 [details]
Dear maintainers,  Please find attached the locale definition for <locale> to be considered for inclusion in glibc.
Comment 2 kokoye2007 2019-11-04 19:45:30 UTC
Hi sir
Mike, Keld and other geeks
Help me again.

We are running l10n-mnw and Locales 


With regards
Comment 3 Mike FABIAN 2019-11-05 10:38:37 UTC
Created attachment 12064 [details]
mnw_MM slighly changed

I made  some small changes an attached the changed file here.

First change was to convert the MS-DOS line endings to unix line endings.

Then I removed some trailing whitespace.

And I changed the territory from "Mon" to "Myanmar" (the Mon state is part of Myanmar and the other locales all seem to have the country there and not some region within a country).

All changes except the line ending change look like this:

--- localedata/locales/mnw_MM.orig	2019-11-05 11:10:59.012321146 +0100
+++ localedata/locales/mnw_MM	2019-11-05 11:09:10.119571405 +0100
@@ -11,14 +11,14 @@
 
 LC_IDENTIFICATION
 title        "Mon language locale for Myanmar"
-source       "Mon Localization Team https://facebook.com/groups/monlocalization/"
+source       "Mon Localization Team https:////facebook.com//groups//monlocalization//"
 address      "Mawlamyine, Mon State, Myanmar"
 contact      "Talachan Mon"
 email        "talachanmon@gmail.com"
 tel          ""
 fax          ""
 language     "Mon"
-territory    "Mon"
+territory    "Myanmar"
 revision     "1"
 date         "2019-10-27"
 
@@ -60,31 +60,31 @@
 % ဂျာန်နျူအာရဳ, ဝှေဝ်ဗြူအာရဳ, မာတ်ချ်, အေပြေယ်လ်, မေ, ဂျုန်, ဂျူလာၚ်, အဝ်ဂါတ်, သိပ်တီဗာ, အံက်တဝ်ဗာ, နဝ်ဝါမ်ဗာ, ဒဳသီဗာ
 mon           "<U1002><U103B><U102C><U1014><U103A><U1014><U103B><U1030><U1021><U102C><U101B><U1033>";/
      "<U101D><U103E><U1031><U101D><U103A><U1017><U103C><U1030><U1021><U102C><U101B><U1033>";/
-     "<U1019><U102C><U1010><U103A><U1001><U103B><U103A>";/	 
-     "<U1021><U1031><U1015><U103C><U1031><U101A><U103A><U101C><U103A>";/	 
-     "<U1019><U1031>";/	 
-     "<U1002><U103B><U102F><U1014><U103A>";/	 
-     "<U1002><U103B><U1030><U101C><U102C><U105A><U103A>";/	 
-     "<U1021><U101D><U103A><U1002><U102B><U1010><U103A>";/	 
-     "<U101E><U102D><U1015><U103A><U1010><U102E><U1017><U102C>";/	 
-     "<U1021><U1036><U1000><U103A><U1010><U101D><U103A><U1017><U102C>";/	 
+     "<U1019><U102C><U1010><U103A><U1001><U103B><U103A>";/
+     "<U1021><U1031><U1015><U103C><U1031><U101A><U103A><U101C><U103A>";/
+     "<U1019><U1031>";/
+     "<U1002><U103B><U102F><U1014><U103A>";/
+     "<U1002><U103B><U1030><U101C><U102C><U105A><U103A>";/
+     "<U1021><U101D><U103A><U1002><U102B><U1010><U103A>";/
+     "<U101E><U102D><U1015><U103A><U1010><U102E><U1017><U102C>";/
+     "<U1021><U1036><U1000><U103A><U1010><U101D><U103A><U1017><U102C>";/
      "<U1014><U101D><U103A><U101D><U102B><U1019><U103A><U1017><U102C>";/
      "<U1012><U1033><U101E><U102E><U1017><U102C>"
 % ဂျာန်, ဝှေဝ်, မာတ်, အေ, မေ, ဂျုန်, ဂျူ, အဝ်, သိပ်, အံက်, နဝ်, ဒဳ
-abmon         "<U1002><U103B><U102C><U1014><U103A>";/
-       "<U101D><U103E><U1031><U101D><U103A>";/	   
-       "<U1019><U102C><U1010><U103A>";/	   
-       "<U1021><U1031>";/	   
-       "<U1019><U1031>";/	   
-       "<U1002><U103B><U102F><U1014><U103A>";/	   
-       "<U1002><U103B><U1030>";/	   
-       "<U1021><U101D><U103A>";/	   
-       "<U101E><U102D><U1015><U103A>";/	   
-       "<U1021><U1036><U1000><U103A>";/	   
-       "<U1014><U101D><U103A>";/	   
+abmon  "<U1002><U103B><U102C><U1014><U103A>";/
+       "<U101D><U103E><U1031><U101D><U103A>";/
+       "<U1019><U102C><U1010><U103A>";/
+       "<U1021><U1031>";/
+       "<U1019><U1031>";/
+       "<U1002><U103B><U102F><U1014><U103A>";/
+       "<U1002><U103B><U1030>";/
+       "<U1021><U101D><U103A>";/
+       "<U101E><U102D><U1015><U103A>";/
+       "<U1021><U1036><U1000><U103A>";/
+       "<U1014><U101D><U103A>";/
        "<U1012><U1033>"
 % အဒိုတ်, စန်, အၚာ, ဗုဒ္ဓဝါ, ဗြဴဗ္တိ, သိုက်, သ္ၚိသဝ်
-day           "<U1021><U1012><U102D><U102F><U1010><U103A>";/
+day  "<U1021><U1012><U102D><U102F><U1010><U103A>";/
      "<U1005><U1014><U103A>";/
      "<U1021><U105A><U102C>";/
      "<U1017><U102F><U1012><U1039><U1013><U101D><U102B>";/
@@ -92,7 +92,7 @@
      "<U101E><U102D><U102F><U1000><U103A>";/
      "<U101E><U1039><U105A><U102D><U101E><U101D><U103A>"
 % ဒိုတ်, စန်, ၚာ, ဝါ, တိ, သိုက်, သဝ်
-abday         "<U1012><U102D><U102F><U1010><U103A>";/
+abday  "<U1012><U102D><U102F><U1010><U103A>";/
        "<U1005><U1014><U103A>";/
        "<U105A><U102C>";/
        "<U101D><U102B>";/
@@ -107,7 +107,7 @@
 am_pm         "<U1002><U101A><U1038>";"<U1010><U1039><U105A><U1032><U1005><U1031><U105A><U103A>"
 t_fmt_ampm    "%OI:%OM:%OS %p"
 % ၀၀, ၀၁, ၀၂, ၀၃, ၀၄, ၀၅, ၀၆, ၀၇, ၀၈, ၀၉, ၁၀, ၁၁, ၁၂, ၁၃, ၁၄, ၁၅, ၁၆, ၁၇, ၁၈, ၁၉, ၂၀, ၂၁, ၂၂, ၂၃, ၂၄, ၂၅, ၂၆, ၂၇, ၂၈, ၂၉, ၃၀, ၃၁, ၃၂, ၃၃, ၃၄, ၃၅, ၃၆, ၃၇, ၃၈, ၃၉, ၄၀, ၄၁, ၄၂, ၄၃, ၄၄, ၄၅, ၄၆, ၄၇, ၄၈, ၄၉, ၅၀, ၅၁, ၅၂, ၅၃, ၅၄, ၅၅, ၅၆, ၅၇, ၅၈, ၅၉, ၆၀, ၆၁, ၆၂, ၆၃, ၆၄, ၆၅, ၆၆, ၆၇, ၆၈, ၆၉, ၇၀, ၇၁, ၇၂, ၇၃, ၇၄, ၇၅, ၇၆, ၇၇, ၇၈, ၇၉, ၈၀, ၈၁, ၈၂, ၈၃, ၈၄, ၈၅, ၈၆, ၈၇, ၈၈, ၈၉, ၉၀, ၉၁, ၉၂, ၉၃, ၉၄, ၉၅, ၉၆, ၉၇, ၉၈, ၉၉
-alt_digits    "<U1040><U1040>";/
+alt_digits  "<U1040><U1040>";/
             "<U1040><U1041>";/
             "<U1040><U1042>";/
             "<U1040><U1043>";/
Comment 4 Mike FABIAN 2019-11-05 10:40:32 UTC
-source       "Mon Localization Team https://facebook.com/groups/monlocalization/"
+source       "Mon Localization Team https:////facebook.com//group//monlocalization//"

This change is because of

    escape_char /

the / characters need to be quoted.
Comment 5 Mike FABIAN 2019-11-05 11:23:05 UTC
The double quotes at "grouping" and "mon_grouping" need  to be removed as well:

diff --git a/localedata/locales/mnw_MM b/localedata/locales/mnw_MM
index 2ff60db167..cf451eda5e 100644
--- a/localedata/locales/mnw_MM
+++ b/localedata/locales/mnw_MM
@@ -212,7 +212,7 @@ END LC_TIME
 LC_NUMERIC
 decimal_point "."
 thousands_sep ","
-grouping      "3;3"
+grouping      3;3
 END LC_NUMERIC
 
 LC_MONETARY
@@ -220,7 +220,7 @@ currency_symbol    "K"
 int_curr_symbol    "MMK "
 mon_decimal_point  "."
 mon_thousands_sep  ","
-mon_grouping       "3;3"
+mon_grouping       3;3
 positive_sign      ""
 negative_sign      "-"
 frac_digits        2


Otherwise one gets the error:

mnw_MM.UTF-8...locales/mnw_MM:215: LC_NUMERIC: syntax error
locales/mnw_MM:223: LC_MONETARY: syntax error
[error] LC_NUMERIC: field `grouping' not defined
[error] LC_MONETARY: field `mon_grouping' not defined

when running localedef.
Comment 6 kokoye2007 2019-11-05 13:58:54 UTC
[error] LC_ADDRESS: terminology language code `mnw' not defined
[error] LC_ADDRESS: language abbreviation `mnw' not defined
[error] LC_ADDRESS: language abbreviation `mnw' not defined


we just need to fix

lang_ab - two-letter ISO 639 code if available, empty if not (when only three-letter code is available)

lang_term - three-letter ISO 639-2/T (Terminology) code

lang_lib - three-letter ISO 639-2/B (Bibliographic) code

```
lang_ab      "mnw"
lang_term    "mnw"
lang_lib     "mnw"
```


@@ -11,7 +11,7 @@

 LC_IDENTIFICATION
 title        "Mon language locale for Myanmar"
-source       "Mon Localization Team https:////facebook.com//groups//monlocalization"
+source       "Mon Localization Team https:////facebook.com//groups//monlocalization//"
 address      "Mawlamyine, Mon State, Myanmar"
 contact      "Talachan Mon"
 email        "talachanmon@gmail.com"
@@ -212,17 +212,17 @@
 LC_NUMERIC
 decimal_point "."
 thousands_sep ","
-grouping      3
+grouping      "3;3"
 END LC_NUMERIC

 LC_MONETARY
 currency_symbol    "K"
 int_curr_symbol    "MMK "
-positive_sign      ""
-negative_sign      "-"
 mon_decimal_point  "."
 mon_thousands_sep  ","
-mon_grouping       3
+mon_grouping       "3;3"
+positive_sign      ""
+negative_sign      "-"
 frac_digits        2
 int_frac_digits    2
 p_cs_precedes      0
@@ -271,13 +271,10 @@
 country_name "<U1017><U105F><U102C>"
 country_post "Myanmar"
 country_ab2  "MM"
-country_ab3  "MMR"
 country_num  104
 country_car  "MYA"
-country_isbn  99971
 % မန်
 lang_name    "<U1019><U1014><U103A>"
-lang_ab             "mnw"
 lang_term    "mnw"
 lang_lib     "mnw"
 END LC_ADDRESS
Comment 7 kokoye2007 2019-11-05 14:01:35 UTC
Created attachment 12065 [details]
fix group and other
Comment 8 kokoye2007 2019-11-05 17:44:41 UTC
Comment on attachment 12065 [details]
fix group and other

--- /home/kokoye2007/Downloads/mnw_MM.txt	2019-11-05 20:19:40.170119388 +0630
+++ mnw_MM.txt	2019-11-05 20:22:31.981106935 +0630
@@ -11,7 +11,7 @@
 
 LC_IDENTIFICATION
 title        "Mon language locale for Myanmar"
-source       "Mon Localization Team https:////facebook.com//groups//monlocalization//"
+source       "Mon Localization Team https:////facebook.com//groups//monlocalization"
 address      "Mawlamyine, Mon State, Myanmar"
 contact      "Talachan Mon"
 email        "talachanmon@gmail.com"
@@ -212,17 +212,17 @@
 LC_NUMERIC
 decimal_point "."
 thousands_sep ","
-grouping      "3;3"
+grouping      3
 END LC_NUMERIC
 
 LC_MONETARY
 currency_symbol    "K"
 int_curr_symbol    "MMK "
-mon_decimal_point  "."
-mon_thousands_sep  ","
-mon_grouping       "3;3"
 positive_sign      ""
 negative_sign      "-"
+mon_decimal_point  "."
+mon_thousands_sep  ","
+mon_grouping       3
 frac_digits        2
 int_frac_digits    2
 p_cs_precedes      0
@@ -271,12 +271,12 @@
 country_name "<U1017><U105F><U102C>"
 country_post "Myanmar"
 country_ab2  "MM"
+country_ab3  "MMR"
 country_num  104
 country_car  "MYA"
+country_isbn  99971
 % မန်
 lang_name    "<U1019><U1014><U103A>"
-lang_term    "mnw"
-lang_lib     "mnw"
 END LC_ADDRESS
 
 LC_TELEPHONE
Comment 9 kokoye2007 2019-11-05 18:12:17 UTC
Created attachment 12066 [details]
mnw_MM

Fix and Update
Comment 10 kokoye2007 2019-11-05 18:13:06 UTC
Created attachment 12067 [details]
mnw_MM fix groups error message

Fix Diff File
Comment 11 Mike FABIAN 2019-11-06 06:29:16 UTC
(In reply to kokoye2007 from comment #9)
> Created attachment 12066 [details]
> mnw_MM
> 
> Fix and Update

lang_ab	     "mnw"

I think lang_ab should be empty because Mon does not have a iso639-1 code,
i.e.

lang_ab ""
Comment 12 Sourceware Commits 2019-11-06 07:16:07 UTC
The master branch has been updated by Mike Fabian <mfabian@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=c5fbd7c3ea4d3f8863e8d195feda64c4a8c29e8a

commit c5fbd7c3ea4d3f8863e8d195feda64c4a8c29e8a
Author: Talachan Mon <talachanmon@gmail.com>
Date:   Tue Nov 5 10:35:55 2019 +0100

    Add new locale: mnw_MM (Mon language spoken in Myanmar) [BZ #25139]
Comment 13 Sourceware Commits 2019-11-06 07:16:12 UTC
The master branch has been updated by Mike Fabian <mfabian@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=4ecd584908109db3ac9bf4aca307ddd44e029275

commit 4ecd584908109db3ac9bf4aca307ddd44e029275
Author: Mike FABIAN <mfabian@redhat.com>
Date:   Tue Nov 5 12:26:58 2019 +0100

    Add mnw language code [BZ #25139]
Comment 14 Mike FABIAN 2020-01-10 16:00:33 UTC
Will be  in the next release (2.31)