Bug 24543 - stapbpf breaks when cpu0 is disabled
Summary: stapbpf breaks when cpu0 is disabled
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: bpf (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-05-09 18:52 UTC by Serhei Makarov
Modified: 2019-06-24 18:29 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Serhei Makarov 2019-05-09 18:52:52 UTC
There is code in stapbpf to handle the case when some cpu cores are disabled.

However, certain things in stapbpf.cxx are still hardcoded to cpu0 (e.g. perf group fd). If cpu0 is disabled, stapbpf doesn't work.
Comment 1 Serhei Makarov 2019-06-24 18:29:20 UTC
Strictly speaking cpu0 is not always safe or possible to disable. But I was able to do so on a test vm, so the fix has been committed just in case. (As usual, before the fix stapbpf's error message is based on a failing syscall return code, which fails to reveal the reason why things don't work.)