Bug 24410 - Empty change report emitted for libpoppler-qt5.so.1.18.0
Summary: Empty change report emitted for libpoppler-qt5.so.1.18.0
Status: RESOLVED FIXED
Alias: None
Product: libabigail
Classification: Unclassified
Component: default (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Dodji Seketeli
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-02 13:49 UTC by Dodji Seketeli
Modified: 2019-04-08 10:00 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dodji Seketeli 2019-04-02 13:49:47 UTC
This is from https://taskotron.fedoraproject.org/artifacts/all/3363376a-5474-11e9-9d55-525400fc9f92/tests.yml/poppler-0.73.0-8.fc30.log

Basically, when comparing poppler-qt5-0.73.0-4.fc30.x86_64.rpm and poppler-qt5-0.73.0-8.fc30.x86_64.rpm, here is what I am getting:

$ abipkgdiff --d1 old/poppler-debuginfo-0.73.0-4.fc30.x86_64.rpm  --d1 old/poppler-qt5-debuginfo-0.73.0-4.fc30.x86_64.rpm --devel1 old/poppler-qt5-devel-0.73.0-4.fc30.x86_64.rpm --d2 new/poppler-debuginfo-0.73.0-8.fc30.x86_64.rpm --d2 new/poppler-qt5-debuginfo-0.73.0-8.f\
c30.x86_64.rpm --devel2 new/poppler-qt5-devel-0.73.0-8.fc30.x86_64.rpm  old/poppler-qt5-0.73.0-4.fc30.x86_64.rpm new/poppler-qt5-0.73.0-8.fc30.x86_64.rpm
================ changes of 'libpoppler-qt5.so.1.18.0'===============
  Functions changes summary: 0 Removed, 1 Changed (45 filtered out), 0 Added functions
  Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

  1 function with some indirect sub-type change:

    [C]'method QList<Poppler::EmbeddedFile*> Poppler::Document::embeddedFiles() const' at poppler-qt5.h:1543:1 has some indirect sub-type changes:
      return type changed:
        type size hasn't changed
        1 data member change:



================ end of changes of 'libpoppler-qt5.so.1.18.0'===============

$

That is, the "1 data member change:" string should be followed by the description of said change.
Comment 1 Dodji Seketeli 2019-04-08 09:39:11 UTC
Also, I have noticed that all the changes that have been suppressed by libabigail in this comparison are spurious.  We ought to fix that.
Comment 2 Dodji Seketeli 2019-04-08 10:00:41 UTC
This should now be fixed by commits from https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=522ac2595db1aa511133c5b25cc8546b47bdd11f to https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=1b831382d0f779806b82959d1e788f81d2c383cf.  The fix hould be available in the 1.7 version of the library.