Bug 24409 - Updates for TW locales
Summary: Updates for TW locales
Status: UNCONFIRMED
Alias: None
Product: glibc
Classification: Unclassified
Component: localedata (show other bugs)
Version: 2.35
: P2 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-04-02 10:10 UTC by Wei-Lun Chao
Modified: 2022-02-17 09:53 UTC (History)
3 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:
fweimer: security-


Attachments
Patch to update TW locales (3.24 KB, patch)
2019-04-02 10:10 UTC, Wei-Lun Chao
Details | Diff
Patch to update TW locales (3.27 KB, patch)
2019-07-05 02:56 UTC, Wei-Lun Chao
Details | Diff
Patch to update TW locales (3.24 KB, patch)
2021-04-21 05:28 UTC, Wei-Lun Chao
Details | Diff
Patch to update TW locales (5.10 KB, patch)
2021-11-19 14:58 UTC, Wei-Lun Chao
Details | Diff
Patch to update TW locales (5.07 KB, patch)
2021-11-26 05:00 UTC, Wei-Lun Chao
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wei-Lun Chao 2019-04-02 10:10:05 UTC
Created attachment 11718 [details]
Patch to update TW locales

localedata: Updates for Taiwanese locales

After a broad review of Taiwanese locales, attached updates are made for consistency and correctness.

Changelog:
* localedata/locales/cmn_TW: Header clean up; Remove space (abmon); Add (week); Change (thousands_sep) to avoid confusion; Simplify (yesexpr) and (noexpr).
* localedata/locales/hak_TW: Likewise and add collation.
* localedata/locales/nan_TW: Likewise and add collation.
* localedata/locales/lzh_TW: Likewise and add collation.
Comment 1 Wei-Lun Chao 2019-04-19 09:05:52 UTC
See also BZ #24293 which embraves this one.
Comment 2 Wei-Lun Chao 2019-05-10 05:23:14 UTC
[Ping]
Two presentations from me: (sorry in chinese only)
https://speakerdeck.com/bluebat/locales-for-chinese-dialects
https://speakerdeck.com/bluebat/look-at-yue-desktop
Comment 3 Wei-Lun Chao 2019-07-05 02:56:25 UTC
Created attachment 11885 [details]
Patch to update TW locales

Borrowed "first_weekday 2" from bug #24682 to make a new patch.

Changelog:
* localedata/locales/cmn_TW: Header clean up; Remove space (abmon); Add (week); Change (first_weekday); Change (thousands_sep) to avoid confusion; Simplify (yesexpr) and (noexpr).
* localedata/locales/hak_TW: Likewise and add collation.
* localedata/locales/nan_TW: Likewise and add collation.
* localedata/locales/lzh_TW: Likewise and add collation.
Comment 4 Wei-Lun Chao 2019-08-07 02:56:24 UTC
A testing package for Fedora users:
https://github.com/rpmsphere/noarch/raw/master/g/glibc-sinitic-langpacks-2.29-99.noarch.rpm
Comment 5 Wei-Lun Chao 2019-10-16 06:00:52 UTC
[PING]
Another experimental RPM package for testing L10N:
https://github.com/rpmsphere/noarch/raw/master/l/language-pack-sinitic-2019.10-1.noarch.rpm
Comment 7 Wei-Lun Chao 2019-11-25 05:22:31 UTC
[PING]
Patching OK for GLIBC 2.30
Comment 8 Wei-Lun Chao 2019-12-26 01:31:03 UTC
[PING]
Please give comments and help update.
Comment 9 Wei-Lun Chao 2020-05-19 01:39:09 UTC
[PING]
Testing packages OK on fedora 32:
https://github.com/rpmsphere/noarch/raw/master/g/glibc-sinitic-langpacks-2.31-99.noarch.rpm
Comment 10 Wei-Lun Chao 2020-07-08 05:39:43 UTC
[PING]
Caution! It could be overrided by /usr/lib/locale/locale-archive from glibc-all-langpacks.
Comment 11 Wei-Lun Chao 2020-10-16 09:09:25 UTC
Patch-passed for version 2.32
Please confirm.
Comment 13 Wei-Lun Chao 2020-11-12 08:57:11 UTC
[PING]
The above package works on Fedora 33.
Comment 14 Wei-Lun Chao 2021-04-08 01:48:24 UTC
[PING]
Patch-passed for version 2.33
Please confirm.
Comment 15 Carlos O'Donell 2021-04-08 03:12:30 UTC
(In reply to Wei-Lun Chao from comment #14)
> [PING]
> Patch-passed for version 2.33
> Please confirm.

Please review the contribution checklist for submitting patches:
https://sourceware.org/glibc/wiki/Contribution%20checklist

The most important part of a locale change is the rationale for the change from the existing locale to the new changes.

Generally the strongest rationale is that the data is being harmonized with CLDR from Unicode.

Your next step here would be to prepare a patch to send to libc-alpha@sourceware.org with a commit message that is sufficiently detailed to explain the changes. I would avoid spurious white space changes in the patch and focus on the exact meaningful changes.
Comment 16 Wei-Lun Chao 2021-04-21 05:28:38 UTC
Created attachment 13393 [details]
Patch to update TW locales

patch modified as suggested by H.J. Lu:
* using thin-space <U2009> rather than ['] as thousands separator
* keep using 一月…十二月 in lzh_TW
Comment 17 Wei-Lun Chao 2021-11-19 14:58:01 UTC
Created attachment 13799 [details]
Patch to update TW locales
Comment 18 Wei-Lun Chao 2021-11-26 05:00:38 UTC
Created attachment 13806 [details]
Patch to update TW locales

[PATCH v4]
* fix email header
* add a missing character in abmon in lzh_TW