Bug 24287 - "make check" failed with tcl 8.5
Summary: "make check" failed with tcl 8.5
Status: RESOLVED FIXED
Alias: None
Product: binutils
Classification: Unclassified
Component: binutils (show other bugs)
Version: 2.33
: P2 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2019-03-01 16:20 UTC by H.J. Lu
Modified: 2019-03-05 10:14 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description H.J. Lu 2019-03-01 16:20:19 UTC
On RHEL 7 with tcl 8.5, I got

$ make check RUNTESTFLAGS=discard.exp
...
Running /export/gnu/import/git/sources/binutils-gdb/ld/testsuite/ld-discard/discard.exp
...
ERROR: (DejaGnu) proc "lmap x {{ }} {
        if { [string length $x] && [string length $as_additional_flags] } {
            append x " "
        }
        append x $as_additional_flags
        regsub {\[big_or_little_endian\]} $x  [big_or_little_endian] x
        expr {$x}
    }" does not exist.
The error code is NONE
The info on the error is:
invalid command name "lmap"
    while executing
"::tcl_unknown lmap x {{ }} {
        if { [string length $x] && [string length $as_additional_flags] } {
            append x " "
        }
        ap..."
    ("uplevel" body line 1)
    invoked from within
"uplevel 1 ::tcl_unknown $args"

=== ld Summary ===

/export/build/gnu/binutils/build-x86_64-linux/ld/ld-new 2.32.51.20190227

make[3]: *** [check-DEJAGNU] Error 1
make[3]: Leaving directory `/export/build/gnu/binutils/build-x86_64-linux/ld'
make[2]: *** [check-am] Error 2
make[2]: Leaving directory `/export/build/gnu/binutils/build-x86_64-linux/ld'
make[1]: *** [check-recursive] Error 1
make[1]: Leaving directory `/export/build/gnu/binutils/build-x86_64-linux/ld'
make: *** [check] Error 2

A patch is posted at

https://sourceware.org/ml/binutils/2019-02/msg00132.html
Comment 1 cvs-commit@gcc.gnu.org 2019-03-05 10:11:13 UTC
The master branch has been updated by Nick Clifton <nickc@sourceware.org>:

https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=093f70ccd3d8366de1faae3335bbe2eebd2a75d4

commit 093f70ccd3d8366de1faae3335bbe2eebd2a75d4
Author: Matthew Malcomson <matthew.malcomson@arm.com>
Date:   Tue Mar 5 10:09:50 2019 +0000

    Allow multiple tests to be run on systems with older versions of TCL installed.
    
    	PR 24287
    	* testsuite/lib/binutils-common.exp (run_dump_test): Replace a use
    	of "lmap" with a "foreach" loop.
Comment 2 Nick Clifton 2019-03-05 10:14:54 UTC
Sorry about missing that.  Patch applied.