Bug 23991 - shell-container typo in run_command_array
Summary: shell-container typo in run_command_array
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: build (show other bugs)
Version: 2.30
: P2 normal
Target Milestone: 2.32
Assignee: dj@redhat.com
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-12-14 20:32 UTC by Carlos O'Donell
Modified: 2020-03-03 12:49 UTC (History)
3 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:
fweimer: security-

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos O'Donell 2018-12-14 20:32:08 UTC 
In support/shell-container.c (run_command_arra):

228       if (new_stderr != 2)
229         {
230           dup2 (new_stderr, 2);
231           close (new_stdout);
232         }

This looks like a typo. We should close new_stderr after the dup2.
Comment 1 dj@redhat.com 2020-03-02 22:33:10 UTC 
Fixed in 542160f0b6a7c26758c9575a8876f6624a5dd65f