Bug 23905 - Make libabigail support Fortran binaries
Summary: Make libabigail support Fortran binaries
Status: RESOLVED FIXED
Alias: None
Product: libabigail
Classification: Unclassified
Component: default (show other bugs)
Version: unspecified
: P2 enhancement
Target Milestone: ---
Assignee: Dodji Seketeli
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2018-11-21 21:13 UTC by Arzhan Kinzhalin
Modified: 2018-11-29 14:02 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed: 2018-11-22 00:00:00


Attachments
.so to reproduce with. (381.10 KB, application/x-sharedlib)
2018-11-21 21:13 UTC, Arzhan Kinzhalin
Details
coredump (301.91 KB, application/x-xz)
2018-11-21 21:14 UTC, Arzhan Kinzhalin
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Arzhan Kinzhalin 2018-11-21 21:13:43 UTC
Created attachment 11407 [details]
.so to reproduce with.

Running abidw on the attached .so results in abort(). Happens with 1.5.0 and the latest master.

Some shallow analysis I've done indicates that while construction a function definition, and attempting to recover its parameters type if finds that it's of wrong type. The output is the following:

$./abidw hdf5-1.10.4-15.x86_64/usr/lib64/libhdf5_fortran.so.100.1.2
in die_pretty_print_type at: ../../src/abg-dwarf-reader.cc:11088: execution should not have reached this point!
Aborted (core dumped)
Comment 1 Arzhan Kinzhalin 2018-11-21 21:14:20 UTC
Created attachment 11408 [details]
coredump
Comment 2 Dodji Seketeli 2018-11-22 10:16:10 UTC
Hello,

Thank you for reporting this issue.

I could reproduce it just fine, thank you for making it easy for me.

I think the issue is "just" that libabigail doesn't yet support reading binaries originating from the Fortran language.

I'll add that support for Fortran now then, as I am seeing more reports about users wanting this.
Comment 3 Arzhan Kinzhalin 2018-11-24 08:18:58 UTC
Oh, makes sense to me now. Thank you!
Comment 4 Dodji Seketeli 2018-11-29 14:02:59 UTC
This should be now fixed with the commit https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=2c6ecfad6fe61c02ef78db97d1b96039c0892fa0 in the master branch of the upstream repository.

Thanks for submitting this problem report.