Created attachment 11210 [details]
U-Boot sections after
since the commit 702d167134149f420ea3bcbc194d63a2653a0c27 (powerpc common-page-size), U-Boot for some armhf targets is not linked properly anymore. Issue lies in following linker script: http://git.denx.de/?p=u-boot.git;a=blob;f=arch/arm/cpu/u-boot.lds
If "CONSTANT(COMMONPAGESIZE)" is replaced with "0x1000", U-Boot works properly. Alternatively, if aforementioned commit is reverted, it works too.
It looks like COMMONPAGESIZE is 0. You can find attached sections info before and after that commit.
Created attachment 11211 [details]
U-Boot sections before
Sorry, I put same description to both files.
Attachment which has unaligned __secure_start is the result of linking after mentioned commit.
Description fixed. The problem was caused by this part of the commit
+ * ldmain.c (main): Move config.maxpagesize and
+ config.commonpagesize initialization to..
+ * ldemul.c (after_parse_default): ..here.
in conjunction with the fact that the align argument in an output section statement is evaluated only once. ie. ld really only expects an integer there, not an expression that might change.
The master branch has been updated by Alan Modra <email@example.com>:
Author: Alan Modra <firstname.lastname@example.org>
Date: Sun Aug 26 14:23:38 2018 +0930
Delay evaluation of alignment expressions in output sections
git commit 702d16713 broke expressions using CONSTANT(COMMONPAGESIZE)
in ALIGN or SUBALIGN of output section statements, because these
optional fields were evaluated at script parse time and the patch in
question delayed setting of config.commonpagesize. The right thing to
do is keep the tree representation of those fields for later
* ldlang.h (section_alignment): Make it an expression tree.
* ldlang.c (topower): Delete.
(output_section_statement_newfunc): Adjust initialization.
(init_os): Evaluate section_alignment.
(size_input_section): Evaluate subsection_alignment.
(lang_enter_output_section_statement): Don't evaluate here.
(lang_new_phdr): Use exp_get_vma rather than exp_get_value_int.
* ldexp.h (exp_get_value_int): Delete.
* ldexp.c (exp_get_value_int): Delete.
(exp_get_power): New function.
* emultempl/pe.em (place_orphan): Build expression for section
* emultempl/pep.em (place_orphan): Likewise.
* testsuite/ld-scripts/pr23571.t: New test.
* testsuite/ld-scripts/align.exp: Run it.
Patch applied. I'll note that the U-Boot script would have worked if the align expression had been put on the left of the colon. Like this:
It works, thanks!