Bug 23559 - stapbpf string literal support for octal and hex escape codes
Summary: stapbpf string literal support for octal and hex escape codes
Status: CLOSED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: bpf (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Serhei Makarov
URL:
Keywords:
Depends on: 22330
Blocks:
  Show dependency tree / graph
 
Reported: 2018-08-21 21:21 UTC by Serhei Makarov
Modified: 2019-06-18 17:00 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Serhei Makarov 2018-08-21 21:21:15 UTC 
I've written a patch for this. But currently, it's not enabled because putting arbitrary non-printing characters into the trace_printk() buffer seems to be a good recipe for chaos.

So this issue also depends on PR22330.
Comment 1 Serhei Makarov 2019-06-18 16:47:36 UTC 
Committed a patch which allows all non-printing characters except '\0' (which is dropped silently). This allows ansi_colors examples to work with stapbpf.

Closing this PR, will open new ones if any edge cases come up.
Comment 2 William Cohen 2019-06-18 17:00:58 UTC 
Commit 9f888f1630cce8527f14d93d8b638952e4c45f71 seems to work fine for the ansi_colors and ansi_colors2 examples and they now work with the bpf backend.