hr_HR file has wrong values for thousands_sep and mon_thousands_sep. Current value is "<U202F>" it should be "." Arguments for this change: 1) CLDR uses "." for grouping and "," as the decimal point. See common/main/hr.xml file. 2) All CNB (Croatian National Bank) reports has . as thousands separator (www.hnb.hr). 3) All receipts that you will see in Croatia has . as thousands separator. 4) All banking apps use . as thousands separator (checked few random banks). 5) Browsed through Croatian Constitution, again "." as thousands separator. 6) Croatian Ministry of Finance use ".". 7)And most unpopular reason that I can think of: Windows 10 (and all previous versions) has "." as thousands and "," for decimal separator (numeric and monetary). You just forced me to find pc with windows :D
Created attachment 10965 [details] hr_HR patched file
I have also browsed through older versions of glibc. It seems that all have wrong separators for thousands and decimal. thousands should be "." and decimal should be ",". BR, Krešimir
Created attachment 10966 [details] Fixing mon_thousands_sep and thousands_sep to "." OK, bug report and arguments for it are valid. Provided patch isn't a patch but a full localedata file. Therefore this patch is provided which changes only affected portion of the locale.
Hi Dragan, Your patch is OK. But in comment you written "," in instead "." BR, Krešimir
Fixed comment :)
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GNU C Library master sources". The branch, master has been updated via ea76691a7507b052a15b9dddb5847afa2b57d2a4 (commit) from 573963e32ffac46d9891970ddebde2ac3212c5c0 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=ea76691a7507b052a15b9dddb5847afa2b57d2a4 commit ea76691a7507b052a15b9dddb5847afa2b57d2a4 Author: Dragan Stanojevic - Nevidljivi <invisible@hidden-city.net> Date: Mon Apr 23 16:54:31 2018 +0200 hr_HR locale: fix thousands_sep and mon_thousands_sep [BZ #23094] * localedata/locales/hr_HR: fix thousands_sep and mon_thousands_sep ----------------------------------------------------------------------- Summary of changes: ChangeLog | 6 ++++++ localedata/locales/hr_HR | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-)
Fixed in glibc master
How was this commit tested? I'm seeing failures of stdlib/tst-strfmon_l now, for locale hr_HR.UTF-8.
(In reply to joseph@codesourcery.com from comment #8) > I'm seeing failures of stdlib/tst-strfmon_l now, for locale hr_HR.UTF-8. For the record: a fix for those errors has been proposed at https://sourceware.org/ml/libc-alpha/2018-04/msg00491.html
(In reply to joseph@codesourcery.com from comment #8) > How was this commit tested? I'm seeing failures of stdlib/tst-strfmon_l > now, for locale hr_HR.UTF-8. Sorry, I thought I had run make check but apparently I just looked at the result from a previous run. I’ll fix it immediately!
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "GNU C Library master sources". The branch, master has been updated via e5aea5c314f1f2c4e31e2ca29578ca1a9f2b9b55 (commit) from 9320ca88a197d3620d3553ccc2d9402d981d7e23 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=e5aea5c314f1f2c4e31e2ca29578ca1a9f2b9b55 commit e5aea5c314f1f2c4e31e2ca29578ca1a9f2b9b55 Author: Mike FABIAN <mfabian@redhat.com> Date: Tue Apr 24 15:04:43 2018 +0200 Fix tst-strfmon_l test for hr_HR locale The test needs to be adapted for the change in the thousands separators: “hr_HR locale: fix thousands_sep and mon_thousands_sep” [BZ #23094] ----------------------------------------------------------------------- Summary of changes: stdlib/tst-strfmon_l.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-)