Bug 22989 - Crash on mingw-w64 build caused by commit 4c2da80c2bdff7761e
Summary: Crash on mingw-w64 build caused by commit 4c2da80c2bdff7761e
Status: RESOLVED DUPLICATE of bug 22762
Alias: None
Product: binutils
Classification: Unclassified
Component: ld (show other bugs)
Version: 2.30
: P2 normal
Target Milestone: ---
Assignee: Nick Clifton
URL: https://trac.torproject.org/projects/...
Keywords:
Depends on:
Blocks:
 
Reported: 2018-03-21 12:48 UTC by Nicolas Vigier
Modified: 2018-03-31 12:22 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed: 2018-03-21 00:00:00

Attachments
Proposed patch (1.54 KB, patch)
2018-03-21 16:34 UTC, Nick Clifton 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nicolas Vigier 2018-03-21 12:48:38 UTC 
We are building Tor Browser for Windows using mingw-w64, gcc 5.4.0 and binutils.

A build done using binutils commit 4c2da80c2bdff7761eb5b3d9c03ffa0c9958b6b9 is working fine.
A build done using binutils commit ca6f2be7f6bc638fd4fad48def1fae4ae4d7906e is crashing when we try to start the browser.

In a debugger we can see a lot of messages like:
  warning: 0f64:0944 @ 01846240 - LdrpSnapThunk - WARNING: Hint index 0x119 for procedure "NtEnumerateKey" in DLL "ntdll.dll" is invalid

  warning: 0f64:0944 @ 01846256 - LdrpSnapThunk - WARNING: Hint index 0x3bb for procedure "RtlIntegerToUnicodeString" in DLL "ntdll.dll" is invalid

  warning: 0f64:0944 @ 01846287 - LdrpSnapThunk - WARNING: Hint index 0x26e for procedure "RtlAppendUnicodeStringToString" in DLL "ntdll.dll" is invalid

  warning: 0f64:0944 @ 01846303 - LdrpSnapThunk - WARNING: Hint index 0x4a7 for procedure "RtlStringFromGUID" in DLL "ntdll.dll" is invalid

Here is a build with commit 4c2da80c2bdff7761eb5b3d9c03ffa0c9958b6b9:
https://people.torproject.org/~boklm/builds/testbuild.4c2da80c2bdff7761eb5b3d9c03ffa0c9958b6b9/torbrowser-install-8.0a2_en-US.exe
f34b0776b28772ce285ff789ae493f6b1bfa086bdc79ff079996ab5ac1ad5344  testbuild.4c2da80c2bdff7761eb5b3d9c03ffa0c9958b6b9/torbrowser-install-8.0a2_en-US.exe

Here is a build with commit ca6f2be7f6bc638fd4fad48def1fae4ae4d7906e:
https://people.torproject.org/~boklm/builds/testbuild.ca6f2be7f6bc638fd4fad48def1fae4ae4d7906e/torbrowser-install-8.0a2_en-US.exe
221e70cc10a2f1d701966043ae3017d7c31e0623b023154f8029989601aac92a  testbuild.ca6f2be7f6bc638fd4fad48def1fae4ae4d7906e/torbrowser-install-8.0a2_en-US.exe

We are using 2 binutils patches:
https://gitweb.torproject.org/builders/tor-browser-build.git/tree/projects/binutils
Comment 1 Nick Clifton 2018-03-21 16:34:59 UTC 
Created attachment 10905 [details]
Proposed patch

Hi Nicolas,

  It looks like this PR might be a duplicate of PR 22762.

  Unfortunately the patch to fix that PR just missed the 2.30 release.
  (It is in the latest 2.30 branch sources, but not in the 2.30 release
  tarball).

  Would you mind trying out the patch from that PR (attached here for
  your convenience) and letting me know if it solves the problem ?

Cheers
  Nick
Comment 2 Nicolas Vigier 2018-03-21 16:50:24 UTC 
Thanks! I tried a build using master, and I can confirm that the issue is fixed.

*** This bug has been marked as a duplicate of bug 22762 ***