Bug 22382 - Error in tpi_PG locale
Summary: Error in tpi_PG locale
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: localedata (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: 2.27
Assignee: Mike FABIAN
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-11-01 15:54 UTC by Claude Paroz
Modified: 2017-11-02 17:01 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed: 2017-11-02 00:00:00
fweimer: security-


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Claude Paroz 2017-11-01 15:54:17 UTC
While syncing data to my lh.2xlibre.net Web app, I encountered an error while importing the new tpi_PG locale file. There is a missing ";\" after the "Februeri" month name.

As a side note, I see less unicode sequence codes like <U0063> in locale files. Do you have a new policy in place? Would you like patches for more global replacements for all files?
Comment 1 Mike FABIAN 2017-11-02 09:10:25 UTC
(In reply to Claude Paroz from comment #0)
> While syncing data to my lh.2xlibre.net Web app, I encountered an error
> while importing the new tpi_PG locale file. There is a missing ";\" after
> the "Februeri" month name.

You are right, it is surprising that it seems to work nevertheless:

[root@taka /]# LC_ALL=tpi_PG.UTF-8 locale -k mon
mon="Janueri;Februeri;Mas;Epril;Me;Jun;Julai;Ogas;Septemba;Oktoba;Novemba;Desemba"

The problem was already there when the <U...> code points were used, it
is just easier to see it now because of less clutter.

> As a side note, I see less unicode sequence codes like <U0063> in locale
> files. Do you have a new policy in place?

We agreed that it is OK to use ASCII directly, so one has to use <U....>
only for stuff which is not ASCII.

> Would you like patches for more
> global replacements for all files?

I think yes. When we started to use more ASCII a while ago, we did not
do global replacements and changed it only in the files we touched anyway
to see whether it would cause any problems. As far as I know we did not
encounter any problems so far, so it seems OK to do it globally.
Comment 2 Claude Paroz 2017-11-02 14:01:20 UTC
(In reply to Mike FABIAN from comment #1)
> > As a side note, I see less unicode sequence codes like <U0063> in locale
> > files. Do you have a new policy in place?
> 
> We agreed that it is OK to use ASCII directly, so one has to use <U....>
> only for stuff which is not ASCII.
> 
> > Would you like patches for more
> > global replacements for all files?
> 
> I think yes. When we started to use more ASCII a while ago, we did not
> do global replacements and changed it only in the files we touched anyway
> to see whether it would cause any problems. As far as I know we did not
> encounter any problems so far, so it seems OK to do it globally.

Opened https://sourceware.org/bugzilla/show_bug.cgi?id=22387 for that part.
Comment 3 Sourceware Commits 2017-11-02 16:39:26 UTC
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  5baac970a8fee1dd9ddb8d1af2af79a09a85abcc (commit)
      from  ef11081fed788f65aa2361c0df49e7a9fd2903d7 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=5baac970a8fee1dd9ddb8d1af2af79a09a85abcc

commit 5baac970a8fee1dd9ddb8d1af2af79a09a85abcc
Author: Mike FABIAN <mfabian@redhat.com>
Date:   Thu Nov 2 13:21:01 2017 +0100

    tpi_PG locale: fix syntax error [BZ #22382]
    
    	[BZ #22382]
    	* localedata/locales/tpi_PG (LC_TIME): Fix syntax error.
    	* localedata/locales/tpi_PG: Add standard header.

-----------------------------------------------------------------------

Summary of changes:
 ChangeLog                 |    6 ++++++
 localedata/locales/tpi_PG |    9 ++++++++-
 2 files changed, 14 insertions(+), 1 deletions(-)
Comment 4 Mike FABIAN 2017-11-02 17:01:31 UTC
Fixed in glibc master.