Bug 21644 - abipkgdiff does not emit diagnostics about comparison errors
Summary: abipkgdiff does not emit diagnostics about comparison errors
Status: RESOLVED FIXED
Alias: None
Product: libabigail
Classification: Unclassified
Component: default (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Dodji Seketeli
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2017-06-20 23:37 UTC by Ben Woodard
Modified: 2017-07-06 13:26 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Woodard 2017-06-20 23:37:37 UTC
This one is rather perplexing.
Using the dodji/kabidiff branch

[ben@localhost build]$ tools/abipkgdiff $testpath//00558688-pdtoolkit-gnu-ohpc/pdtoolkit-gnu-ohpc-3.23-1.ohpc.1.3.8.x86_64.rpm $testpath//00558688-pdtoolkit-gnu-ohpc/pdtoolkit-gnu-ohpc-3.23-1.ohpc.1.3.8.x86_64.rpm 
================ changes of 'maqao-2.2.0-intel64-xeonphi'===============
================ end of changes of 'maqao-2.2.0-intel64-xeonphi'===============

================ changes of 'edg44-pdt_roseparse'===============
================ end of changes of 'edg44-pdt_roseparse'===============

================ changes of 'f951'===============
================ end of changes of 'f951'===============

================ changes of 'cc1'===============
================ end of changes of 'cc1'===============

================ changes of 'pdtflint'===============
================ end of changes of 'pdtflint'===============

================ changes of 'gfortran'===============
================ end of changes of 'gfortran'===============

[ben@localhost build]$ echo $?
1

So what are the differences?

The reproducing file is to big to attach but it can be downloaded from:
http://copr-be.cloud.fedoraproject.org/results/adrian/ohpc-gcc7/epel-7-x86_64/00558688-pdtoolkit-gnu-ohpc/pdtoolkit-gnu-ohpc-3.23-1.ohpc.1.3.8.x86_64.rpm
Comment 1 Ben Woodard 2017-06-21 01:01:00 UTC
There is really only program that causes this problem but I have 4 different versions of the package in my test repo.
Comment 2 Dodji Seketeli 2017-07-05 16:29:06 UTC
I am looking into this and it appears that the binaries in question (e.g, maqao-2.2.0-intel64-xeonphi) have been stripped from their ELF symbols, and they have no associated debug info, so libabigail cannot operate on them.

I am working on emitting better diagnostics in those cases.
Comment 3 Dodji Seketeli 2017-07-06 13:26:06 UTC
This was just fixed by commit in the master branch.

abipkgdiff now emits diagnostics about the *errors* it encounters while trying to compare files from packages.  Here is what the command line now looks like:

$  abipkgdiff pdtoolkit-gnu-ohpc/pdtoolkit-gnu-ohpc-3.23-1.ohpc.1.3.8.x86_64.rpm pdtoolkit-gnu-ohpc-3.23-1.ohpc.1.3.8.x86_64.rpm
==== Error happened during processing of maqao-2.2.0-intel64-xeonphi: ====
could not find debug info
could not load ELF symbols
==== End of error for maqao-2.2.0-intel64-xeonphi ====
==== Error happened during processing of edg44-pdt_roseparse: ====
could not find debug info
could not load ELF symbols
==== End of error for edg44-pdt_roseparse ====
==== Error happened during processing of pdtflint: ====
could not find debug info
could not load ELF symbols
==== End of error for pdtflint ====