Created attachment 9968 [details] patch containing alternative The documentation for --relax isn't clear about whether or not the use of --no-relax causes an error when the feature is not supported on a platform. The sentence in question is: "On platforms where --relax is accepted the option --no-relax can be used to disable the feature." (there's a comma missing after "accepted") The set containing all platforms has previously been divided into those where it is 1. supported or 2. ignored. ("On platforms where this is not supported, --relax is accepted, but ignored.") If I'm not mistaken, the conditional "On platforms where --relax is accepted" means "all platforms". Imho, "[On all platforms,] --no-relax can be used to disable the feature" should then also distinguish between supported and merely ignored. There's a patch with a proposal attached.
Created attachment 9976 [details] Proposed patch Hi Weremaid, > The documentation for --relax isn't clear about whether or not the use of > --no-relax causes an error when the feature is not supported on a platform. Personally I think that the documentation is OK as it is, but I do not object to rewording it if you think that it will help. > If I'm not mistaken, the conditional "On platforms where --relax is > accepted" means "all platforms". No, I would not agree with that. > Imho, "[On all platforms,] --no-relax can be used to disable the feature" > should then also distinguish between supported and merely ignored. OK. > There's a patch with a proposal attached. The patch is a good start, but I think that if we are clarifying this text then we can go further and make things even more straightforward. What do you think of this revised version of your patch ? Cheers Nick
The patch looks good:)
The master branch has been updated by Nick Clifton <nickc@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=ccd9fae5d57b9a16d00d70d9dad916133ff1ea70 commit ccd9fae5d57b9a16d00d70d9dad916133ff1ea70 Author: Nick Clifton <nickc@redhat.com> Date: Mon Aug 10 16:35:57 2020 +0100 Improve the documentation of the linker's --relax option. PR ld/21351 * ld.texi: Clarify the behaviour of the --relax and --no-relax options on systems that do not support them.
Patch applied.