Dear all, Using AFLFast (https://github.com/mboehme/aflfast), a fork of AFL, we found an input causing addr2line to crash. Valgrind says that it is an invalid write. The bug was found on Ubuntu 14.04 & binutils was checked out from https://github.com/bminor/binutils-gdb repository. Its commit is 268ebe95201d2ebdcf68cad9dc67ff6d1e25be9e (Fri Nov 18 14:15:12 2016) To reproduce: printf "\x0b\x01\x00\x30\x00\x00\x00\x00\x00\x00\x00\x00\x30\x30\x30\x30\x1c\x00\x00\x00\x30\x30\x30\x30\x00\x00\x00\x00\x00\x01\x00\x00\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x00\x00\x00\x00\x64\x30\x30\x30\x30\x30\x30\x30\x00\x00\x00\x00\x64\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x1b\x01\x00\x00\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30\x30" > fd addr2line s -e fd ASAN says: ASAN:DEADLYSIGNAL ================================================================= ==47318==ERROR: AddressSanitizer: SEGV on unknown address 0x000000000000 (pc 0x7f7e6ee49029 bp 0xffffffffffffffff sp 0x7ffe86e5a8b0 T0) #0 0x7f7e6ee49028 in __vsprintf_chk (/lib/x86_64-linux-gnu/libc.so.6+0x109028) #1 0x7f7e6ee48f7c in __sprintf_chk (/lib/x86_64-linux-gnu/libc.so.6+0x108f7c) #2 0x5515c9 in sprintf /usr/include/x86_64-linux-gnu/bits/stdio2.h:33 #3 0x5515c9 in aout_32_find_nearest_line ../../bfd/aoutx.h:2814 #4 0x40cb9d in find_address_in_section ../../binutils/addr2line.c:187 #5 0x42186f in bfd_map_over_sections ../../bfd/section.c:1395 #6 0x40b19a in translate_addresses ../../binutils/addr2line.c:265 #7 0x40b19a in process_file ../../binutils/addr2line.c:402 #8 0x40b19a in main ../../binutils/addr2line.c:509 #9 0x7f7e6ed61f44 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x21f44) #10 0x40c806 (/home/ubuntu/subjects/binutils-asan/obj-asan/binutils/addr2line+0x40c806) AddressSanitizer can not provide additional info. SUMMARY: AddressSanitizer: SEGV (/lib/x86_64-linux-gnu/libc.so.6+0x109028) in __vsprintf_chk ==47318==ABORTING Valgrind says: ==46463== Invalid write of size 1 ==46463== at 0x5144029: __vsprintf_chk (vsprintf_chk.c:86) ==46463== by 0x5143F7C: __sprintf_chk (sprintf_chk.c:31) ==46463== by 0x638930: sprintf (stdio2.h:33) ==46463== by 0x638930: aout_32_find_nearest_line (aoutx.h:2814) ==46463== by 0x40762C: find_address_in_section (addr2line.c:187) ==46463== by 0x43D55B: bfd_map_over_sections (section.c:1395) ==46463== by 0x405F12: translate_addresses (addr2line.c:265) ==46463== by 0x405F12: process_file (addr2line.c:402) ==46463== by 0x405F12: main (addr2line.c:509) ==46463== Address 0x0 is not stack'd, malloc'd or (recently) free'd ==46463== ==46463== ==46463== Process terminating with default action of signal 11 (SIGSEGV) ==46463== Access not within mapped region at address 0x0 ==46463== at 0x5144029: __vsprintf_chk (vsprintf_chk.c:86) ==46463== by 0x5143F7C: __sprintf_chk (sprintf_chk.c:31) ==46463== by 0x638930: sprintf (stdio2.h:33) ==46463== by 0x638930: aout_32_find_nearest_line (aoutx.h:2814) ==46463== by 0x40762C: find_address_in_section (addr2line.c:187) ==46463== by 0x43D55B: bfd_map_over_sections (section.c:1395) ==46463== by 0x405F12: translate_addresses (addr2line.c:265) ==46463== by 0x405F12: process_file (addr2line.c:402) ==46463== by 0x405F12: main (addr2line.c:509)
The master branch has been updated by Nick Clifton <nickc@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=50455f1ab2935f7321215dfa681745c9b1cb5b19 commit 50455f1ab2935f7321215dfa681745c9b1cb5b19 Author: Nick Clifton <nickc@redhat.com> Date: Thu Dec 1 10:15:07 2016 +0000 Fix seg-fault running addr2line on a corrupt binary. PR binutils/20891 * aoutx.h (find_nearest_line): Handle the case where the main file name and the directory name are both empty.
Hi Thuan, Thanks for reporting this problem. I have checked in a small patch which fixes the bug. Cheers Nick
This is CVE-2017-7225
The master branch has been updated by Stephen Casner <slcasner@sourceware.org>: https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=31af1e68af26f5cae209de3530d0455b8a944b2d commit 31af1e68af26f5cae209de3530d0455b8a944b2d Author: Stephen Casner <casner@acm.org> Date: Wed Jun 3 17:43:45 2020 -0700 Copy several years of fixes from bfd/aoutx.h to bfd/pdp11.c. * pdp11.c (some_aout_object_p): 4c1534c7a2a - Don't set EXEC_P for files with relocs. (aout_get_external_symbols): 6b8f0fd579d - Return if count is zero. 0301ce1486b PR 22306 - Handle stringsize of zero, and error for any other size that doesn't qcover the header word. bf82069dce1 PR 23056 - Allocate an extra byte at the end of the string table, and zero it. (translate_symbol_table): 0d329c0a83a PR 22887 - Print an error message and set bfd_error on finding an invalid name string offset. (add_to_stringtab): INLINE -> inline (pdp11_aout_swap_reloc_in): 116acb2c268 PR 22887 - Correct r_index bound check. (squirt_out_relocs): e2996cc315d PR 20921 - Check for and report any relocs that could not be recognised. 92744f05809 PR 20929 - Check for relocs without an associated symbol. (find_nearest_line): 808346fcfcf PR 23055 - Check that the symbol name exists and is long enough, before attempting to see if it is for a .o file. c3864421222 - Correct case for N_SO being the last symbol. 50455f1ab29 PR 20891 - Handle the case where the main file name and the directory name are both empty. e82ab856bb4 PR 20892 - Handle the case where function name is empty. (aout_link_add_symbols): e517df3dbf7 PR 19629 - Check for out of range string table offsets. 531336e3a0b PR 20909 - Fix off-by-one error in check for an illegal string offset. (aout_link_includes_newfunc): Add comment. (pdp11_aout_link_input_section): ad756e3f9e6 - Return with an error on unexpected relocation type rather than ASSERT.