Bug 20161 - VM_FAULT_MINOR has been removed from rawhide kernels
Summary: VM_FAULT_MINOR has been removed from rawhide kernels
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: runtime (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-05-27 17:58 UTC by David Smith
Modified: 2016-05-27 18:09 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Smith 2016-05-27 17:58:28 UTC
On rawhide kernels (4.7.0-0.rc0.git5.1.fc25.x86_64), VM_FAULT_MINOR is no longer defined. This causes problems for tapset/linux/memory.stp:

====
# stap -p4 --compatible=2.9 /discer.farm/es/scratch/dsmith/systemtap/src/testsuite/buildok/memory-embedded.stp^M
/tmp/stapMCPqTA/stap_43205e040089fef25e73c052e0db182d_6958_src.c: In function 'function___global_vm_fault_contains__overload_0':
/tmp/stapMCPqTA/stap_43205e040089fef25e73c052e0db182d_6958_src.c:742:34: error: 'VM_FAULT_MINOR' undeclared (first use in this function)
  case 2: res = STAP_ARG_value == VM_FAULT_MINOR; break;
                                  ^~~~~~~~~~~~~~
/tmp/stapMCPqTA/stap_43205e040089fef25e73c052e0db182d_6958_src.c:742:34: note: each undeclared identifier is reported only once for each function it appears in
scripts/Makefile.build:291: recipe for target '/tmp/stapMCPqTA/stap_43205e040089fef25e73c052e0db182d_6958_src.o' failed
make[4]: *** [/tmp/stapMCPqTA/stap_43205e040089fef25e73c052e0db182d_6958_src.o] Error 1
Makefile:1432: recipe for target '_module_/tmp/stapMCPqTA' failed
make[3]: *** [_module_/tmp/stapMCPqTA] Error 2
WARNING: kbuild exited with status: 2
Pass 4: compilation failed.  [man error::pass4]
====

The following kernel commit is the cause:

====
commit 0e8fb9312fbaf1a687dd731b04d8ab3121c4ff5a                                 
Author: Jan Kara <jack@suse.cz>                                                 
Date:   Thu Mar 17 14:19:55 2016 -0700                                          
                                                                                
    mm: remove VM_FAULT_MINOR                                                   
                                                                                
    The define has a comment from Nick Piggin from 2007:                        
                                                                                
     /* For backwards compat. Remove me quickly. */                             
                                                                                
    I guess 9 years should not be too hurried sense of 'quickly' even for       
    kernel measures.                                                            
====
Comment 1 David Smith 2016-05-27 18:09:13 UTC
Fixed in commit 59a9c75.