Bug 19141 - Libabigail doesn't support common ELF symbols (defined in SHN_COMMON sections)
Summary: Libabigail doesn't support common ELF symbols (defined in SHN_COMMON sections)
Status: RESOLVED FIXED
Alias: None
Product: libabigail
Classification: Unclassified
Component: default (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Dodji Seketeli
URL:
Keywords:
: 19142 (view as bug list)
Depends on:
Blocks:
 
Reported: 2015-10-15 22:52 UTC by Ben Woodard
Modified: 2016-01-20 13:23 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
reproducing ELF file. (6.80 KB, application/x-object)
2015-10-15 22:52 UTC, Ben Woodard 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ben Woodard 2015-10-15 22:52:17 UTC 
Created attachment 8723 [details]
reproducing ELF file.

This appears to be a new one:

hype356@ben:~/bin/abidw --abidiff /collab/usr/global/tools/Vis5d/Vis5d+/src/irix_6.5_64/vis5d+-1.3.0-beta/util/get5d.o
abidw: ../../src/abg-reader.cc:2265: abigail::ir::string_elf_symbols_map_sptr abigail::xml_reader::build_elf_symbol_db(abigail::xml_reader::read_context&, xmlNode*, bool): Assertion `i->second->is_main_symbol()' failed.
Aborted (core dumped)
Comment 1 Ben Woodard 2016-01-06 21:19:41 UTC 
bash-4.1$ ~/bin/abidw --abidiff /collab/usr/global/tools/Vis5d/Vis5d+/src/irix_6.5_64/vis5d+-1.3.0-beta/util/get5d.o
abidw: ../../src/abg-reader.cc:2279: abigail::ir::string_elf_symbols_map_sptr abigail::xml_reader::build_elf_symbol_db(abigail::xml_reader::read_context&, xmlNode*, bool): Assertion `i->second->is_main_symbol()' failed.
Aborted (core dumped)

So the line number seems to have moved to 2279 but the error seems to be the same.

This is with the latest 1.0 RC1 git.
Comment 2 Ben Woodard 2016-01-11 21:57:00 UTC 
I did not test for regressions by running through the whole 130k item list. However, by running on just the files that previously asserted I was able to run through this very quickly. 

This is now the most common assert with 3 failures in the latest git.
Comment 3 Dodji Seketeli 2016-01-20 12:10:00 UTC 
I was looking at bug #19141 and after poking at it for a while, I realized it was the same as this one.  So I am taking this one too.
Comment 4 Dodji Seketeli 2016-01-20 12:11:01 UTC 
*** Bug 19142 has been marked as a duplicate of this bug. ***
Comment 5 Dodji Seketeli 2016-01-20 13:23:06 UTC 
This should now be fixed by commit https://sourceware.org/git/?p=libabigail.git;a=commit;h=640b3a2f59b48b869db871e46f3190555219e17b in the master branch.

Thanks for reporting this issue!