Bug 18618 - sync Chechen locale definitions with other *_RU locales
Summary: sync Chechen locale definitions with other *_RU locales
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: localedata (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: 2.23
Assignee: Dmitry V. Levin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-07-01 10:42 UTC by Arslanbek Astemirov
Modified: 2015-10-29 16:36 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:
fweimer: security-


Attachments
changes in Chechen locale file (507 bytes, patch)
2015-07-01 10:42 UTC, Arslanbek Astemirov
Details | Diff
fixed "language" in LC_IDENTIFICATION section (457 bytes, patch)
2015-07-02 11:45 UTC, Arslanbek Astemirov
Details | Diff
proposed fix (674 bytes, patch)
2015-07-03 09:25 UTC, Dmitry V. Levin
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Arslanbek Astemirov 2015-07-01 10:42:10 UTC
Created attachment 8405 [details]
changes in Chechen locale file

Make changes to Chechen locale file please
Comment 1 Dmitry V. Levin 2015-07-01 15:28:59 UTC
(In reply to Arslanbek Astemirov from comment #0)
> Make changes to Chechen locale file please

Could you also fix "language" in LC_IDENTIFICATION section, please?
Comment 2 Arslanbek Astemirov 2015-07-02 11:45:43 UTC
Created attachment 8407 [details]
fixed "language" in LC_IDENTIFICATION section

I fixed "language" in LC_IDENTIFICATION section
Comment 3 Pravin S 2015-07-02 13:04:06 UTC
Hi Arslanbek,

Do you have any references for these changes?
Comment 4 Arslanbek Astemirov 2015-07-02 13:41:35 UTC
(In reply to Pravin S from comment #3)
> Hi Arslanbek,
> 
> Do you have any references for these changes?

Excuse I didn't understand. What references?
Comment 5 Pravin S 2015-07-02 14:10:19 UTC
(In reply to Arslanbek Astemirov from comment #4)
> (In reply to Pravin S from comment #3)
> > Hi Arslanbek,
> > 
> > Do you have any references for these changes?
> 
> Excuse I didn't understand. What references?

i.e. How do you know First weekday is "2"? 

But looking at patch more careful this looks as a Correction rather than any changes. So it looks good to me as well. 

You need to drop this patch on libc-alpha mailing list. For reference see https://sourceware.org/ml/libc-alpha/2015-06/msg00564.html
Comment 6 Dmitry V. Levin 2015-07-02 14:10:59 UTC
With regards to the LC_NUMERIC section fix, a cleaner change would be

LC_NUMERIC
copy "ru_RU"
END LC_NUMERIC

This is the way other *_RU locales define LC_NUMERIC.
Comment 7 Arslanbek Astemirov 2015-07-03 06:25:49 UTC
(In reply to Pravin S from comment #5)
> (In reply to Arslanbek Astemirov from comment #4)
> > (In reply to Pravin S from comment #3)
> > > Hi Arslanbek,
> > > 
> > > Do you have any references for these changes?
> > 
> > Excuse I didn't understand. What references?
> 
> i.e. How do you know First weekday is "2"? 
> 
> But looking at patch more careful this looks as a Correction rather than any
> changes. So it looks good to me as well. 
> 
> You need to drop this patch on libc-alpha mailing list. For reference see
> https://sourceware.org/ml/libc-alpha/2015-06/msg00564.html

Because in Russia the first day of the week Monday, and Chechenya is in structure of Russia.You can simply make changes to this file or not, please?
Comment 8 Arslanbek Astemirov 2015-07-03 06:54:44 UTC
(In reply to Pravin S from comment #5)
> (In reply to Arslanbek Astemirov from comment #4)
> > (In reply to Pravin S from comment #3)
> > > Hi Arslanbek,
> > > 
> > > Do you have any references for these changes?
> > 
> > Excuse I didn't understand. What references?
> 
> i.e. How do you know First weekday is "2"? 
> 
> But looking at patch more careful this looks as a Correction rather than any
> changes. So it looks good to me as well. 
> 
> You need to drop this patch on libc-alpha mailing list. For reference see
> https://sourceware.org/ml/libc-alpha/2015-06/msg00564.html

Because in Russia the first day of the week Monday, and Chechenya is in structure of Russia.You can simply make changes to this file or not, please?
Comment 9 Dmitry V. Levin 2015-07-03 09:25:59 UTC
Created attachment 8408 [details]
proposed fix
Comment 10 Dmitry V. Levin 2015-07-03 09:28:23 UTC
Arslanbek, does the proposed fix look OK?
Comment 11 Arslanbek Astemirov 2015-07-06 08:20:19 UTC
(In reply to Dmitry V. Levin from comment #10)
> Arslanbek, does the proposed fix look OK?

Ok
Comment 12 Sourceware Commits 2015-08-07 11:16:24 UTC
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  db2bcbcb631f1c1aa023ef9f23a968e1ac288423 (commit)
      from  86955bf62e5690f65995ee8055b1ed529f80842b (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=db2bcbcb631f1c1aa023ef9f23a968e1ac288423

commit db2bcbcb631f1c1aa023ef9f23a968e1ac288423
Author: Arslanbek Astemirov <mail.ru>
Date:   Fri Jul 3 09:19:39 2015 +0000

    locales/ce_RU: sync with other *_RU locales
    
    [BZ #18618]
    * locales/ce_RU (LC_IDENTIFICATION): Fix language.
    (LC_TIME): Set first_weekday and first_workday.
    (LC_NUMERIC): Copy ru_RU.

-----------------------------------------------------------------------

Summary of changes:
 NEWS                     |    2 +-
 localedata/ChangeLog     |    7 +++++++
 localedata/locales/ce_RU |   10 ++++------
 3 files changed, 12 insertions(+), 7 deletions(-)
Comment 13 Dmitry V. Levin 2015-08-07 11:19:59 UTC
Fixed in master.