Bug 18122 - [nd_]syscall.exec* probes need work
Summary: [nd_]syscall.exec* probes need work
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: tapsets (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-03-12 14:56 UTC by David Smith
Modified: 2015-03-19 17:23 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Smith 2015-03-12 14:56:55 UTC
The [nd_]syscall.execve and [nd_]syscall.execveat probes are a bit odd and could use a bit of work:

- For some reason, their 'argstr' convenience variables don't have commas between arguments like every other syscall probe.
- They don't report the 'envp' argument.
- The [nd_]syscall.execve probes have no test case. This new test case can be based on the existing execveat test case.
Comment 1 David Smith 2015-03-19 17:23:13 UTC
Fixed in commit bf952a7.

- 'argstr' convenience variables have commas between arguments
- the environment variables are now reported
- a testcase for [nd_]syscall.execve was added
- a few problems with nd_syscall.execveat and nd_syscall.compat_execveat were fixed
- The [nd_]syscall.execve probes were improved by moving them to arch-specific code for kernels < 3.7. This allows us to catch all execve() calls, even ones that fail.