Please provide a small testcase.

BTW, you can try -Wl,-u,qmp_query_uuid for your original problem.

Created attachment 7758 [details]
Reproducer

I linked all the normal .o files from comment 0 to qemu-img-partial.o with "ld -r", and put it into the archive.

Now if I link it with --just-symbols, ld aborts:

"ld -o qemu-img qemu-img-partial.o --just-symbols=iscsi.o libqemuutil.a libqemustub.a $LDFLAGS"

See link.sh in the archive for the necessary libs in $LDFLAGS.

iscsi.o libqemuutil.a libqemustub.a are all included in the archived too, so you can test this command line.

(In reply to H.J. Lu from comment #1)
> BTW, you can try -Wl,-u,qmp_query_uuid for your original problem.

Yes it does help, Thanks. But there are a few more symbols than qmp_query_uuid that need to be pulled in from libqemustub.a, and more will come in the future, so special casing several limited symbols with -Wl,-u,foo is not a good solution compared to --just-symbols.

Fam

(In reply to Fam Zheng from comment #2)
> Created attachment 7758 [details]
> Reproducer
> 

Please provide a self-contained testcase.  I don't have all libraries
this one needed.

(In reply to Fam Zheng from comment #3)
> (In reply to H.J. Lu from comment #1)
> > BTW, you can try -Wl,-u,qmp_query_uuid for your original problem.
> 
> Yes it does help, Thanks. But there are a few more symbols than
> qmp_query_uuid that need to be pulled in from libqemustub.a, and more will
> come in the future, so special casing several limited symbols with
> -Wl,-u,foo is not a good solution compared to --just-symbols.

--just-symbols may not do what you wanted:

'--just-symbols=FILENAME'
     Read symbol names and their addresses from FILENAME, but do not
     relocate it or include it in the output.  This allows your output
     file to refer symbolically to absolute locations of memory defined
     in other programs.  You may use this option more than once.

You can use

for s in $(nm -u iscsi.o | awk '{ print $2 }'); do echo "-Wl,-u,$s"; done

to generate all -Wl,u,xxx.

A small testcase:

[hjl@gnu-6 pr17306]$ cat foo.s
	.data
	.globl foo
foo:
	.quad -1
	.text
	.globl	_start
	.type	_start, @function
_start:
	pushq	foo@GOTPCREL(%rip)
[hjl@gnu-6 pr17306]$ cat lea.s 
	.text
	.globl	bar
	.type	bar, @function
bar:
	movq	foo@GOTPCREL(%rip), %rax
[hjl@gnu-6 pr17306]$ make
gcc -c  -o lea.o lea.s
gcc -c  -o foo.o foo.s
./ld -m elf_x86_64 --just-symbols=lea.o -Bsymbolic -shared -o libfoo.so foo.o
./ld: BFD (GNU Binutils) 2.24.51.20140826 internal error, aborting at /export/gnu/import/git/sources/binutils-gdb/bfd/elf64-x86-64.c line 3824 in elf_x86_64_relocate_section

./ld: Please report this bug.

make: *** [libfoo.so] Error 1
[hjl@gnu-6 pr17306]$

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "gdb and binutils".

The branch, master has been updated
       via  c8831961f9fecf81e90fe7c8c94b47e01ee64662 (commit)
      from  29a9f53e857c5d55df852d0a5d5c41a9247c16a2 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;h=c8831961f9fecf81e90fe7c8c94b47e01ee64662

commit c8831961f9fecf81e90fe7c8c94b47e01ee64662
Author: H.J. Lu <hjl.tools@gmail.com>
Date:   Wed Aug 27 07:59:48 2014 -0700

    Use bfd_is_abs_section to check discarded input section
    
    bfd/
    
    	PR ld/17306
    	* elf32-i386.c (elf_i386_convert_mov_to_lea): Use bfd_is_abs_section
    	to check discarded input section.
    	* elf64-x86-64.c (elf_x86_64_convert_mov_to_lea): Likewise.
    
    ld/testsuite/
    
    	PR ld/17306
    	* ld-i386/i386.exp (i386tests): Add tests for PR ld/17306.
    	* ld-x86-64/x86-64.exp (x86_64tests): Likewise.
    
    	* ld-i386/pr17306a.s: New file.
    	* ld-i386/pr17306b.s: Likewise.
    	* ld-x86-64/pr17306a.s: Likewise.
    	* ld-x86-64/pr17306b.s: Likewise.

-----------------------------------------------------------------------

Summary of changes:
 bfd/ChangeLog                     |    7 +++++++
 bfd/elf32-i386.c                  |    2 +-
 bfd/elf64-x86-64.c                |    2 +-
 ld/testsuite/ChangeLog            |   11 +++++++++++
 ld/testsuite/ld-i386/i386.exp     |    4 ++++
 ld/testsuite/ld-i386/pr17306a.s   |    9 +++++++++
 ld/testsuite/ld-i386/pr17306b.s   |    2 ++
 ld/testsuite/ld-x86-64/pr17306a.s |    9 +++++++++
 ld/testsuite/ld-x86-64/pr17306b.s |    2 ++
 ld/testsuite/ld-x86-64/x86-64.exp |    4 ++++
 10 files changed, 50 insertions(+), 2 deletions(-)
 create mode 100644 ld/testsuite/ld-i386/pr17306a.s
 create mode 100644 ld/testsuite/ld-i386/pr17306b.s
 create mode 100644 ld/testsuite/ld-x86-64/pr17306a.s
 create mode 100644 ld/testsuite/ld-x86-64/pr17306b.s

Linker crash is fixed now.  But I still don't think --just-symbols is
appropriate for your usage since symbols defined in block/iscsi.o are
converted to absolute symbols with value == 0.  You should use -Wl,-u
or -Wl,--whole-archive instead.

Thanks for the fix!

Fam