Bug 15332 - es_CU: locale update
Summary: es_CU: locale update
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: localedata (show other bugs)
Version: 2.13
: P2 enhancement
Target Milestone: 2.27
Assignee: Mike FABIAN
URL:
Keywords:
: 14194 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-04-03 14:18 UTC by Rosniel Arian Montanet
Modified: 2017-09-22 12:00 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:
fweimer: security-


Attachments
Updating data to Cuban locale (1.68 KB, patch)
2013-04-03 14:18 UTC, Rosniel Arian Montanet
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rosniel Arian Montanet 2013-04-03 14:18:10 UTC
Created attachment 6966 [details]
Updating data to Cuban locale

The version that is in the Ubuntu repositories contain erroneous data, I upload the patch below that corrects these errors
Comment 1 keld@keldix.com 2013-04-05 16:09:43 UTC
On Wed, Apr 03, 2013 at 02:18:10PM +0000, ramontanet at estudiantes dot uci.cu wrote:
> http://sourceware.org/bugzilla/show_bug.cgi?id=15332
> 
>              Bug #: 15332
>            Summary: Correcting errors in the old version of the Cuban
>                     locale es_CU
>            Product: glibc
>            Version: 2.13
>             Status: NEW
>           Severity: critical
>           Priority: P2
>          Component: localedata
>         AssignedTo: unassigned@sourceware.org
>         ReportedBy: ramontanet@estudiantes.uci.cu
>                 CC: libc-locales@sourceware.org
>     Classification: Unclassified
> 
> 
> Created attachment 6966 [details]
>   --> http://sourceware.org/bugzilla/attachment.cgi?id=6966
> Updating data to Cuban locale
> 
> The version that is in the Ubuntu repositories contain erroneous data, I upload
> the patch below that corrects these errors

I don't think these are errors. You should not use the SPACE character in LC_MONETARY
as written amounts should be parsable for input, eg in spreadsheets.
And you should not remove my copyright notices.

best regards
Keld
Comment 2 Mike Frysinger 2016-04-18 04:17:52 UTC
*** Bug 14194 has been marked as a duplicate of this bug. ***
Comment 3 Mike Frysinger 2016-04-18 04:39:58 UTC
Comment on attachment 6966 [details]
Updating data to Cuban locale

> LC_COLLATE

i'm not familiar with this collation change.  let's assume it's ok for now.

> LC_MESSAGES
>-copy "es_ES"
>+yesexpr "<U005E><U005B><U0073><U0053><U0079><U0059><U005D><U002E><U002A>"
>+noexpr  "<U005E><U005B><U006E><U004E><U005D><U002E><U002A>"
> END LC_MESSAGES

this change doesn't make sense -- es_ES has that same definition, and it includes yesstr/nostr

>-mon_thousands_sep    "<U0020>"
>+mon_thousands_sep    "<U002E>"

cldr seems to agree with this (es.xml), and it's what es_ES uses

>-p_cs_precedes        0
>+p_cs_precedes        1
>-n_cs_precedes        0
>+n_cs_precedes        1

this looks incorrect.  cldr puts the marker after, not before.

> LC_NUMERIC
>-thousands_sep        ""
>-grouping             0;0
>+thousands_sep        "<U002E>"
>+grouping             3;3

this looks ok

> LC_TIME
>+am_pm   "<U0061><U006D>";"<U0070><U006D>"
>+t_fmt_ampm "<U0025><U0049><U003A><U0025><U004D><U003A><U0025><U0053><U0020>/
>+<U0025><U0070>"

these are the only two changes in this section.  the rest are unchanged from es_ES.
 am_pm "AM";"PM"
 t_fmt_ampm "%I:%M:%S %p"

do you have a spec/reference for this ?
Comment 4 Sourceware Commits 2017-08-31 11:37:54 UTC
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "GNU C Library master sources".

The branch, master has been updated
       via  8715f256302cab595eaf9589b3f4341f1dab020d (commit)
      from  d6e290a6ca822a42a69acde42e7b5003ae185534 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=8715f256302cab595eaf9589b3f4341f1dab020d

commit 8715f256302cab595eaf9589b3f4341f1dab020d
Author: Mike FABIAN <mfabian@redhat.com>
Date:   Thu Aug 31 12:56:07 2017 +0200

    Fix decimal point and thousands separator in es_CU locale to agree with CLDR.
    
    	[BZ #15332]
    	* locales/es_CU (LC_MONETARY): use “,” for mon_decimal_point
    	and “.” for mon_thousands_sep (to agree with CLDR)
    	* locales/es_CU (LC_NUMERIC): Likewise.

-----------------------------------------------------------------------

Summary of changes:
 localedata/ChangeLog     |    8 ++++++++
 localedata/locales/es_CU |    8 ++++----
 2 files changed, 12 insertions(+), 4 deletions(-)
Comment 5 Mike FABIAN 2017-08-31 11:40:39 UTC
I changed the thousands eseparators because that change makes it 
agree with CLDR:

--- a/localedata/locales/es_CU
+++ b/localedata/locales/es_CU
@@ -69,8 +69,8 @@ END LC_MESSAGES
 LC_MONETARY
 int_curr_symbol      "<U0043><U0055><U0050><U0020>"
 currency_symbol      "<U0024>"
-mon_decimal_point    "<U002C>"
-mon_thousands_sep    "<U202F>"
+mon_decimal_point    ","
+mon_thousands_sep    "."
 mon_grouping         3;3
 positive_sign        ""
 negative_sign        "<U002D>"
@@ -85,8 +85,8 @@ n_sign_posn          1
 END LC_MONETARY
 
 LC_NUMERIC
-decimal_point        "<U002C>"
-thousands_sep        ""
+decimal_point        ","
+thousands_sep        "."
 grouping             0;0
 END LC_NUMERIC


I am not sure about the other changes.

As there was no reply for a few years, I am closing this bug as fixed.

If you think further changes are needed, please make a new patch
against current git master, reopen this bug or report a new one
and give references for your changes.