Bug 14892 - hr_HR: first_weekday is not set
Summary: hr_HR: first_weekday is not set
Status: RESOLVED DUPLICATE of bug 10580
Alias: None
Product: glibc
Classification: Unclassified
Component: localedata (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-11-29 11:24 UTC by semiRocket
Modified: 2016-04-16 14:18 UTC (History)
4 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:
fweimer: security-


Attachments
Patch for first_weekday and first_workday (218 bytes, text/plain)
2013-02-14 13:49 UTC, semiRocket
Details

Note You need to log in before you can comment on or make changes to this bug.
Description semiRocket 2012-11-29 11:24:39 UTC
first_weekday and first_workday is not set making applications use wrong first day of the week (Sunday) while it should be Monday.

I've noticed old update file submit in which among other updates is present this one too, but it seems it get rejected for some reason...
http://sourceware.org/bugzilla/show_bug.cgi?id=10580

Please update this two entries for hr_HR locale file.
Comment 1 semiRocket 2013-02-14 13:49:41 UTC
Created attachment 6873 [details]
Patch for first_weekday and first_workday

Please add this patch upstream. Patch alters first_weekday and first_workday to match country locale.
Comment 2 Carlos O'Donell 2013-02-14 15:43:50 UTC
Have you built glibc trunk with this change and does it resolve your problem?

If it does then I'd be more than happy to check it in since it also appears to match the suggested first_* information from BZ#10580.

Could you confirm your patch fixes the issue with trunk please?
Comment 3 Dragan Stanojevic - Nevidljivi 2013-02-14 19:21:06 UTC
It would be great if glibc maintainers would look at #10580 which would solve this and more problems. If you don't won't complete changes in #10580 then consider majority of it, since it waits there for years (at least for a reply from maintainers), although previous croatian maintainer approved the changes as well.
Comment 4 semiRocket 2013-02-15 19:19:45 UTC
(In reply to comment #2)
> Have you built glibc trunk with this change and does it resolve your problem?
> 
> If it does then I'd be more than happy to check it in since it also appears to
> match the suggested first_* information from BZ#10580.
> 
> Could you confirm your patch fixes the issue with trunk please?

I'm sorry but I have no knowledge to compile and test the whole project. I had it edited in this way and compiled using a simple command I don't remember exactly but with distro update my compiled file gone too. And now I can't do even that any more, there are no more. The compiled files had gone as it seems and all it's left is some locale-archive which I have no idea how to update.
Comment 5 semiRocket 2013-02-15 19:27:36 UTC
(In reply to comment #3)
> It would be great if glibc maintainers would look at #10580 which would solve
> this and more problems. If you don't won't complete changes in #10580 then
> consider majority of it, since it waits there for years (at least for a reply
> from maintainers), although previous croatian maintainer approved the changes
> as well.

That would be great it seems you took a lot of effort... it's a shame that is out of main tree for so long.
I'm sorry that I'm not competent enough to review your patch.
Comment 6 Petr Baudis 2013-02-16 00:40:48 UTC
Let's first see if we can quickly resolve bug 10580 and resolve this one separately only if we get stuck for any reason.
Comment 7 semiRocket 2014-11-01 00:12:13 UTC
Please add my changes upstream, I think we waited enough. After all these changes are not that complicated to work around. Patching vanilla locales every time is annoying.
Comment 8 Mike Frysinger 2016-04-15 17:58:48 UTC

*** This bug has been marked as a duplicate of bug 10580 ***
Comment 9 semiRocket 2016-04-15 19:28:53 UTC
Great, some progress. Does closing this bug means that it will be fixed soon with bug 10580?
Comment 10 Mike Frysinger 2016-04-15 22:41:38 UTC
i should have week related fields fixed in all locales for glibc-2.24
Comment 11 semiRocket 2016-04-16 08:23:48 UTC
Hi Mike,

First of all, thank you!

With your patch first weekday is set correctly to monday. I have noticed you've set MINWEEKLEN to 1 which is different from what Dragan and I have been set (4). I am not sure what this does so I can't comment if it is correct or not.


diff --git a/localedata/locales/hr_HR b/localedata/locales/hr_HR
index a1fe6f8..90cee4b 100644
--- a/localedata/locales/hr_HR
+++ b/localedata/locales/hr_HR
@@ -2213,6 +2213,8 @@ d_fmt   "<U0025><U0064><U002E><U0025><U006D><U002E><U0025><U0059>"
 t_fmt   "<U0025><U0054>"
 am_pm   "";""
 t_fmt_ampm ""
+week 7;19971130;1
+first_weekday 2
 END LC_TIME
Comment 12 Mike Frysinger 2016-04-16 14:18:24 UTC
the CLDR says it should be 1.  check out http://cldr.unicode.org for more details.