Bug 14408 - remote_start_remote incorrectly uses immediate_quit
Summary: remote_start_remote incorrectly uses immediate_quit
Status: RESOLVED FIXED
Alias: None
Product: gdb
Classification: Unclassified
Component: remote (show other bugs)
Version: unknown
: P2 normal
Target Milestone: ---
Assignee: Not yet assigned to anyone
URL:
Keywords:
Depends on:
Blocks: 15297
  Show dependency tree / graph
 
Reported: 2012-07-26 17:00 UTC by Tom Tromey
Modified: 2016-04-13 09:45 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Tromey 2012-07-26 17:00:52 UTC 
remote_start_remote modifies immediate_quit but:

* Does not always decrement it.
  In particular it is not cleared along the non-stop path.

* Runs too much code (IMHO) with it non-zero.
  immediate_quit can cause an exception to be thrown at any
  instruction.  It is not safe to leave it set, say, over
  calls into libc and the like.
Comment 1 Pedro Alves 2016-04-13 09:45:42 UTC 
immediate_quit is gone from master.