Bug 12612 - Generate modules compatible with older staprun
Summary: Generate modules compatible with older staprun
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: translator (show other bugs)
Version: unspecified
: P2 minor
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-28 19:57 UTC by Przemysław Pawełczyk
Modified: 2011-03-29 13:36 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments
proposed patch (1.22 KB, patch)
2011-03-28 22:12 UTC, Frank Ch. Eigler
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Przemysław Pawełczyk 2011-03-28 19:57:07 UTC
Older staprun is not able to work properly with recent stap modules. Loading module created by latest version from git using staprun 1.2 gives following kernel messages (repeated many times):

Systemtap Error at _stp_do_relocation:24 STP_RELOCATE message size mismatch (264 vs 136)

Using old staprun is a convenient scenario when admin/developer writes script and deploys resulting module on many machines. Some distributions already have systemtap in their repositories, but it's usually not the recent version.

The solution obviously should not require updating old staprun binaries. Maybe another option similar to --compatibility could be added? There is no point in supporting ancient versions, but 1.2 should not be treated as such.
Comment 1 Frank Ch. Eigler 2011-03-28 22:12:00 UTC
Created attachment 5338 [details]
proposed patch
Comment 2 Przemysław Pawełczyk 2011-03-29 12:48:19 UTC
Thank you, Frank. Works flawlessly (so far).
Comment 3 Frank Ch. Eigler 2011-03-29 13:36:02 UTC
commit a743989