Bug 12573 - ../../src/gdb/breakpoint.c:7445: internal-error: expand_line_sal_maybe: Assertion `found' failed.
Summary: ../../src/gdb/breakpoint.c:7445: internal-error: expand_line_sal_maybe: Asser...
Status: RESOLVED FIXED
Alias: None
Product: gdb
Classification: Unclassified
Component: breakpoints (show other bugs)
Version: HEAD
: P2 critical
Target Milestone: ---
Assignee: Jan Kratochvil
URL:
Keywords:
: 13674 (view as bug list)
Depends on:
Blocks: 12822
  Show dependency treegraph
 
Reported: 2011-03-11 22:35 UTC by Paul Pluzhnikov
Modified: 2012-02-08 19:30 UTC (History)
2 users (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments
compressed binary which triggers the problem (3.60 KB, application/octet-stream)
2011-03-11 22:39 UTC, Paul Pluzhnikov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Pluzhnikov 2011-03-11 22:35:19 UTC
The following test case triggers:

../../src/gdb/breakpoint.c:7445: internal-error: expand_line_sal_maybe: Assertion `found' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Aborted (core dumped)

at current HEAD (7.2.50.20110311-cvs) when setting a breakpoint on Bar::Bar.

As far as I can tell, this is happening because skip_prologue_sal()
returns a "bad" sal when it detects inlined function.

If I make skip_prologue_sal into a no-op, then the breakpoint is set
properly, and there is no crash.

This could be a duplicate of Bug 11031, but I have a test case to reproduce
this with:

/// --- cut --- foo.cc ---
#include <stdlib.h>

struct Foo {
  Foo(int) __attribute__((always_inline));
  int x;
};

struct Bar {
  Bar(int) __attribute__((noinline));

  Foo f;
  int x;
};

Bar::Bar(int i)
  : f(i),
    x(i)
{
}

Foo::Foo(int i)
  : x(i)
{
  free(malloc(1));
}

int main()
{
  Bar b(42);
  return b.x + b.f.x;
}
/// --- cut --- foo.cc ---

Build with:

 g++  -g -O2 foo.cc -fno-omit-frame-pointer

(note: frame pointer is important to repro the problem!)

gdb -ex 'break Bar::Bar' a.out
GNU gdb (GDB) 7.2.50.20110311-cvs
Copyright (C) 2011 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64-unknown-linux-gnu".
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>...
Reading symbols from /tmp/a.out...done.
../../src/gdb/breakpoint.c:7445: internal-error: expand_line_sal_maybe: Assertion `found' failed.
A problem internal to GDB has been detected,
further debugging may prove unreliable.
Aborted (core dumped)



The problem reproduces with gcc version 4.4.3 (Ubuntu 4.4.3-4ubuntu5),
but not with GCC 4.6.0 20110219 (experimental).

I am attach the binary in case your copy of GCC produces something that
does not trigger the problem.
Comment 1 Paul Pluzhnikov 2011-03-11 22:39:26 UTC
Created attachment 5297 [details]
compressed binary which triggers the problem
Comment 2 Paul Pluzhnikov 2011-03-18 16:52:05 UTC
Apparently this has already been reported and a patch proposed:

http://sourceware.org/ml/gdb-patches/2010-07/msg00533.html
https://bugzilla.redhat.com/show_bug.cgi?id=612253
Comment 3 Jan Kratochvil 2011-04-15 20:21:51 UTC
[rfc, 7.3?] -O2 -g breakpoints internal error + prologue skipping
http://sourceware.org/ml/gdb-patches/2011-04/msg00229.html
Comment 4 Sourceware Commits 2011-05-06 15:06:53 UTC
CVSROOT:	/cvs/src
Module name:	src
Changes by:	jkratoch@sourceware.org	2011-05-06 15:06:49

Modified files:
	gdb            : ChangeLog dwarf2read.c symtab.c symtab.h 
	gdb/testsuite  : ChangeLog 
Added files:
	gdb/testsuite/gdb.dwarf2: dw2-skip-prologue.S 
	                          dw2-skip-prologue.c 
	                          dw2-skip-prologue.exp 

Log message:
	gdb/
	PR 12573
	* dwarf2read.c (struct dwarf2_cu): New field has_loclist.
	(producer_is_gcc_ge_4_0): New function.
	(process_full_comp_unit): Set also symtab->locations_valid.  Move the
	symtab->language code.
	(var_decode_location): Set cu->has_loclist.
	* symtab.c (skip_prologue_sal): New variables saved_pc, force_skip and
	skip.  Intialize force_skip from locations_valid.  Move the prologue
	skipping code into two passes.
	* symtab.h (struct symtab): Make the primary field a bitfield.  New
	field locations_valid.
	
	gdb/testsuite/
	PR 12573
	* gdb.dwarf2/dw2-skip-prologue.S: New file.
	* gdb.dwarf2/dw2-skip-prologue.c: New file.
	* gdb.dwarf2/dw2-skip-prologue.exp: New file.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&r1=1.12982&r2=1.12983
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/dwarf2read.c.diff?cvsroot=src&r1=1.529&r2=1.530
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/symtab.c.diff?cvsroot=src&r1=1.271&r2=1.272
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/symtab.h.diff?cvsroot=src&r1=1.181&r2=1.182
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&r1=1.2698&r2=1.2699
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.dwarf2/dw2-skip-prologue.S.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.dwarf2/dw2-skip-prologue.c.diff?cvsroot=src&r1=NONE&r2=1.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.dwarf2/dw2-skip-prologue.exp.diff?cvsroot=src&r1=NONE&r2=1.1
Comment 5 Sourceware Commits 2011-05-06 15:13:42 UTC
CVSROOT:	/cvs/src
Module name:	src
Branch: 	gdb_7_3-branch
Changes by:	jkratoch@sourceware.org	2011-05-06 15:13:38

Modified files:
	gdb            : ChangeLog dwarf2read.c symtab.c symtab.h 
	gdb/testsuite  : ChangeLog 
Added files:
	gdb/testsuite/gdb.dwarf2: dw2-skip-prologue.S 
	                          dw2-skip-prologue.c 
	                          dw2-skip-prologue.exp 

Log message:
	gdb/
	PR 12573
	* dwarf2read.c (struct dwarf2_cu): New field has_loclist.
	(producer_is_gcc_ge_4_0): New function.
	(process_full_comp_unit): Set also symtab->locations_valid.  Move the
	symtab->language code.
	(var_decode_location): Set cu->has_loclist.
	* symtab.c (skip_prologue_sal): New variables saved_pc, force_skip and
	skip.  Intialize force_skip from locations_valid.  Move the prologue
	skipping code into two passes.
	* symtab.h (struct symtab): Make the primary field a bitfield.  New
	field locations_valid.
	
	gdb/testsuite/
	PR 12573
	* gdb.dwarf2/dw2-skip-prologue.S: New file.
	* gdb.dwarf2/dw2-skip-prologue.c: New file.
	* gdb.dwarf2/dw2-skip-prologue.exp: New file.

Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/ChangeLog.diff?cvsroot=src&only_with_tag=gdb_7_3-branch&r1=1.12887.2.20&r2=1.12887.2.21
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/dwarf2read.c.diff?cvsroot=src&only_with_tag=gdb_7_3-branch&r1=1.518.2.2&r2=1.518.2.3
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/symtab.c.diff?cvsroot=src&only_with_tag=gdb_7_3-branch&r1=1.262.2.2&r2=1.262.2.3
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/symtab.h.diff?cvsroot=src&only_with_tag=gdb_7_3-branch&r1=1.173.2.1&r2=1.173.2.2
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/ChangeLog.diff?cvsroot=src&only_with_tag=gdb_7_3-branch&r1=1.2655.2.7&r2=1.2655.2.8
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.dwarf2/dw2-skip-prologue.S.diff?cvsroot=src&only_with_tag=gdb_7_3-branch&r1=NONE&r2=1.1.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.dwarf2/dw2-skip-prologue.c.diff?cvsroot=src&only_with_tag=gdb_7_3-branch&r1=NONE&r2=1.1.2.1
http://sourceware.org/cgi-bin/cvsweb.cgi/src/gdb/testsuite/gdb.dwarf2/dw2-skip-prologue.exp.diff?cvsroot=src&only_with_tag=gdb_7_3-branch&r1=NONE&r2=1.1.2.1
Comment 6 Jan Kratochvil 2011-05-06 15:21:05 UTC
[commit+commit 7.3] -O2 -g breakpoints internal error + prologue skipping (PR 12573)
http://sourceware.org/ml/gdb-patches/2011-05/msg00190.html

GNU gdb (GDB) 7.3.50.20110506-cvs
GNU gdb (GDB) 7.2.90.20110506-cvs
Breakpoint 1 at 0x400600: file foo.cc, line 15. (2 locations)
Comment 7 Tom Tromey 2012-02-08 19:30:49 UTC
*** Bug 13674 has been marked as a duplicate of this bug. ***