Bug 1253 - Fix run time errors in glibc with gcc-4.0
Summary: Fix run time errors in glibc with gcc-4.0
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: hurd (show other bugs)
Version: 2.3.5
: P2 normal
Target Milestone: ---
Assignee: Roland McGrath
URL:
Keywords:
Depends on:
Blocks: libc236
  Show dependency treegraph
 
Reported: 2005-08-26 23:05 UTC by Thomas Schwinge
Modified: 2018-04-19 14:49 UTC (History)
2 users (show)

See Also:
Host: i586-pc-gnu
Target: i586-pc-gnu
Build: i586-pc-gnu
Last reconfirmed:
fweimer: security-


Attachments
Roland's patch to fix run time breakage on a glibc compiled with gcc-4.0 (933 bytes, patch)
2005-09-22 17:17 UTC, Thomas Schwinge
Details | Diff
Additionally needed patch (397 bytes, patch)
2005-09-22 17:18 UTC, Thomas Schwinge
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Schwinge 2005-08-26 23:05:31 UTC
http://sources.redhat.com/ml/libc-alpha/2005-06/msg00053.html

Needs to be fixed on HEAD and glibc-2_3-branch.
Comment 1 Thomas Schwinge 2005-09-22 17:17:35 UTC
Created attachment 666 [details]
Roland's patch to fix run time breakage on a glibc compiled with gcc-4.0
Comment 2 Thomas Schwinge 2005-09-22 17:18:49 UTC
Created attachment 667 [details]
Additionally needed patch

See <URL:http://lists.gnu.org/archive/html/bug-hurd/2005-09/msg00188.html>.
Comment 3 Thomas Schwinge 2005-09-22 17:28:39 UTC
Subject: Re:  Fix run time errors in glibc with gcc-4.0

On Thu, Sep 22, 2005 at 05:17:36PM -0000, tschwinge at gnu dot org wrote:
> Created an attachment (id=666)
                            ^^^
>  --> (http://sourceware.org/bugzilla/attachment.cgi?id=666&action=view)
                                                         ^^^

Oh, my god.

;-)
Comment 4 Sourceware Commits 2005-10-16 09:53:01 UTC
Subject: Bug 1253

CVSROOT:	/cvs/glibc
Module name:	libc
Changes by:	roland@sources.redhat.com	2005-10-16 09:52:58

Modified files:
	sysdeps/mach/hurd/i386: init-first.c 

Log message:
	2005-10-16  Roland McGrath  <roland@frob.com>
	
	[BZ #1253]
	* sysdeps/mach/hurd/i386/init-first.c (init): Make cast kosher.
	(_hurd_stack_setup): Don't declare with arguments and ellipsis.
	Use __builtin_frame_address and __builtin_return_address.
	(_dl_init_first): Likewise.
	* sysdeps/mach/hurd/i386/init-first.c (_cthread_init_routine): Declare
	as weak extern.
	(init): Check for it being undefined.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/mach/hurd/i386/init-first.c.diff?cvsroot=glibc&r1=1.43&r2=1.44

Comment 5 Sourceware Commits 2005-10-16 09:57:46 UTC
Subject: Bug 1253

CVSROOT:	/cvs/glibc
Module name:	libc
Changes by:	roland@sources.redhat.com	2005-10-16 09:57:43

Modified files:
	sysdeps/mach/hurd: dl-sysdep.h 

Log message:
	2005-10-16  Roland McGrath  <roland@frob.com>
	
	[BZ #1253]
	* sysdeps/mach/hurd/dl-sysdep.h
	[SHARED] (DL_ARGV_NOT_RELRO): New macro.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/mach/hurd/dl-sysdep.h.diff?cvsroot=glibc&r1=1.1&r2=1.2

Comment 6 Roland McGrath 2005-10-16 09:58:54 UTC
Please verify that the trunk changes I have committed cover these problems.
Then leave the bug open; I will commit the 2.3 branch after your report.
Comment 7 Sourceware Commits 2005-10-23 01:00:12 UTC
Subject: Bug 1253

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	glibc-2_3-branch
Changes by:	roland@sources.redhat.com	2005-10-23 01:00:05

Modified files:
	sysdeps/mach/hurd: dl-sysdep.h 

Log message:
	2005-10-16  Roland McGrath  <roland@frob.com>
	
	[BZ #1253]
	* sysdeps/mach/hurd/dl-sysdep.h
	[SHARED] (DL_ARGV_NOT_RELRO): New macro.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/mach/hurd/dl-sysdep.h.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.1&r2=1.1.4.1

Comment 8 Sourceware Commits 2005-10-23 01:00:15 UTC
Subject: Bug 1253

CVSROOT:	/cvs/glibc
Module name:	libc
Branch: 	glibc-2_3-branch
Changes by:	roland@sources.redhat.com	2005-10-23 01:00:09

Modified files:
	sysdeps/mach/hurd/i386: init-first.c 

Log message:
	2005-10-16  Roland McGrath  <roland@frob.com>
	
	[BZ #1253]
	* sysdeps/mach/hurd/i386/init-first.c (init): Make cast kosher.
	(_hurd_stack_setup): Don't declare with arguments and ellipsis.
	Use __builtin_frame_address and __builtin_return_address.
	(_dl_init_first): Likewise.
	[BZ #1249]
	* sysdeps/mach/hurd/i386/init-first.c (_cthread_init_routine): Declare
	as weak extern.
	(init): Check for it being undefined.

Patches:
http://sources.redhat.com/cgi-bin/cvsweb.cgi/libc/sysdeps/mach/hurd/i386/init-first.c.diff?cvsroot=glibc&only_with_tag=glibc-2_3-branch&r1=1.43&r2=1.43.4.1

Comment 9 Roland McGrath 2005-10-23 01:01:39 UTC
These changes are now on both branches.
Comment 10 Roland McGrath 2005-11-04 21:43:41 UTC
This bug should be fixed in the 2.3.6 release just made.