Bug 11046 - Wrong kernel version check at __ptsname_internal
Summary: Wrong kernel version check at __ptsname_internal
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: libc (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Ulrich Drepper
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-12-03 04:08 UTC by Herton Ronaldo Krzesinski
Modified: 2014-06-30 20:35 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:
fweimer: security-

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Herton Ronaldo Krzesinski 2009-12-03 04:08:12 UTC 
The commit e2c59de in git repository added a check for old BSD pseudo terminals.
Looks like the check added was inverted, instead of:
#if __LINUX_KERNEL_VERSION >= 131443
should be:
#if __LINUX_KERNEL_VERSION < 131443
at sysdeps/unix/sysv/linux/ptsname.c:131

Also may be the MASTER_P macro should be revisited too and changed accordingly
kernel version?
Comment 1 Ulrich Drepper 2009-12-09 16:35:09 UTC 
Fixed upstream.