Bug 11027 - Class Selector Codepoints not deprecated
Summary: Class Selector Codepoints not deprecated
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: libc (show other bugs)
Version: 2.9
: P3 minor
Target Milestone: ---
Assignee: Ulrich Drepper
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-11-28 00:09 UTC by Philip Prindeville
Modified: 2014-06-30 20:36 UTC (History)
2 users (show)

See Also:
Host: x86_64-unknown-linux-gnu
Target: x86_64-unknown-linux-gnu
Build: x86_64-unknown-linux-gnu
Last reconfirmed:
fweimer: security-

Attachments
Patch for netinet/ip.h to add Class Selector definitions (492 bytes, patch)
2009-11-28 00:10 UTC, Philip Prindeville 		Details | Diff
Patch for netinet/ip.h to add Class Selector definitions (715 bytes, patch)
2009-12-09 22:33 UTC, Philip Prindeville 		Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philip Prindeville 2009-11-28 00:09:12 UTC 
It was correctly pointed out (offline) that the comments in bug #10789 give the
appearance that the DSCP values have completely obsoleted all previous uses of
the IP ToS field.

That's not correct.  The CSx values (CS0..CS7) may (and often do) coexist with
the Assured Forwarding (AFxx) values.

Indeed CS1 precedes the series AF11..AF13, CS2 precedes the series AF21..AF23,
etc. and CS6 immediately succeeds EF.
Comment 1 Philip Prindeville 2009-11-28 00:10:12 UTC 
Created attachment 4417 [details]
Patch for netinet/ip.h to add Class Selector definitions
Comment 2 Philip Prindeville 2009-12-01 23:56:01 UTC 
See also the patch submission to libc-alpha:

http://sourceware.org/ml/libc-alpha/2009-11/msg00111.html
Comment 3 Ulrich Drepper 2009-12-09 22:08:29 UTC 
Where do these names come from?

And if, as you suggest, these names are preferred over the IPTOS_PREC* names
then the latter should be defined in terms of your macros, not the other way around.
Comment 4 Philip Prindeville 2009-12-09 22:33:51 UTC 
Created attachment 4455 [details]
Patch for netinet/ip.h to add Class Selector definitions

This expresses IPTOS_PREC_xxx in terms of IPTOS_CLASS_yyy, and not the
converse, as Ulrich was requesting.
Comment 5 Philip Prindeville 2010-01-08 18:45:22 UTC 
(In reply to comment #4)
> Created an attachment (id=4455)
> Patch for netinet/ip.h to add Class Selector definitions
> 
> This expresses IPTOS_PREC_xxx in terms of IPTOS_CLASS_yyy, and not the
> converse, as Ulrich was requesting.

Uli: I've made these changes as per your request.  Can we have some movement on
this please, or are there other requirements?  Thanks.
Comment 6 Ulrich Drepper 2010-01-15 07:28:35 UTC 
I checked in the patch.