Bug 4138

Summary: Frysk-import lib/elf note reader makes incorrect assumptions about long size/core file architecture
Product: frysk Reporter: Phil Muldoon <pmuldoon>
Component: generalAssignee: Phil Muldoon <pmuldoon>
Status: RESOLVED FIXED    
Severity: normal    
Priority: P2    
Version: unspecified   
Target Milestone: ---   
Host: Target:
Build: Last reconfirmed:
Bug Depends on:    
Bug Blocks: 1595    

Description Phil Muldoon 2007-03-06 18:17:38 UTC
It assumes that the native architecture is the same as the corefile
architecture, leading to testcase fails on reading, for example, x86_64 corefile
on x86 host machines.
Comment 1 Phil Muldoon 2007-03-06 18:19:13 UTC
2007-03-06  Phil Muldoon  <pmuldoon@redhat.com>

        * tests/TestElf.java (testElfCorePrpsNotes): Remove
        brokenX8664XXX/brokenPpcXXX test limiters.

2007-03-02  Phil Muldoon  <pmuldoon@redhat.com>

        * ElfPrpsinfo.java (ElfPrpsinfo): Rewrite note data constructor to
        make allowance for runtime architecture over core file
        architecture.
        * cni/ElfPrpsinfo.cxx (getNoteData): Rewrite. Just pass up raw
        byte data without interpretation.

2007-02-14  Phil Muldoon  <pmuldoon@redhat.com>

        * tests/TestElf.java: (testElfCorePrpsNotes): Disable on x86_64 and PPC
for now.
        (testElfCorePrstatusNotes): Ditto.
Comment 2 Phil Muldoon 2007-03-08 22:06:17 UTC
2007-03-08  Phil Muldoon  <pmuldoon@redhat.com>

	* ElfPrstatus.java: Add get/set for timeval variables.
	Make variables private.

2007-03-07  Phil Muldoon  <pmuldoon@redhat.com>

	* cni/ElfPrstatus.cxx (getNoteData): Rewrite. Return raw note
	data instead of trying to deconstruct.
	* ElfPrstatus.java: Add Timeval variables.
	(decode): New.
	(ElfPrstatus): New constructor, take single note data byte[]
	and parent Elf, and create single thread model.
	* tests/TestElf.java (testElfCorePrpstatusNotes): Remove
	brokenX8664XXX/brokenPpcXXX test limiters.
	Rewrite tests to use .decode.
Comment 3 Phil Muldoon 2007-03-20 14:20:50 UTC
2007-03-19  Phil Muldoon  <pmuldoon@redhat.com>

        * ElfPrAuxv.java (ElfPrAuxv):Make constructor private. Only
        allow calls from decode. Delete old note constructor.
        (decode): New.
        (getNoteData): Make declaration static.
        * cni/ElfPrAuxv.cxx (getNoteData): Do not use extern byte array.
        Instead return byte[] array.
        * tests/TestElf.java (testElfCorePrAuxvNotes): Use decode.

2007-03-13  Phil Muldoon  <pmuldoon@redhat.com>

        * ElfPrstatus.java: Make constructor private. Only
        allow calls from decode.
        * tests/TestElf.java (testElfCorePrpsNotes): Use
        decode function.
        * ElfPrpsinfo.java (decode): New.
        (ElfPrpsinfo): Replace public constructor with private
        constructor. Called from decode.
        (getNoteData): Make CNI declaration static.
Comment 4 Phil Muldoon 2007-04-16 17:22:49 UTC
Fixed in head, due to commited changed. Forgot to close