Bug 2216

Summary: build frysk's c files with -Werror
Product: frysk Reporter: Andrew Cagney <cagney>
Component: generalAssignee: Andrew Cagney <cagney>
Status: RESOLVED FIXED    
Severity: normal CC: dnovillo
Priority: P1    
Version: unspecified   
Target Milestone: ---   
Host: Target:
Build: Last reconfirmed:
Bug Depends on:    
Bug Blocks: 2127, 2188, 2215    

Description Andrew Cagney 2006-01-26 18:55:19 UTC
In addition to java and C++ frysk's .c files should be built with -Werror.
Comment 1 Andrew Cagney 2006-01-26 18:56:54 UTC
First pass:

Index: common/ChangeLog
2006-01-26  Andrew Cagney  <cagney@redhat.com>

        * Makefile.rules (AM_CFLAGS): Define.  Specify -fPIC.

Index: frysk-core/prog/ChangeLog
2006-01-26  Andrew Cagney  <cagney@redhat.com>

        * syscall/syscalls.c: Add missing #include <unistd.h>.
        * syscall/syscallloop.c: Add missing #include <stdlib.h>, and
        <unistd.h>.
        * step/infThreadLoop.c (threadFunc): Return NULL.
        * print/argc.c: Drop envp, and auxv parameters.
        * print/envp.c (main): Drop auxv parameter.
        * print/argv.c (main): Drop envp, and auxv parameters.
        * perf/fork.c: Add missing #include <sys/types.h>, and <unistd.h>.
        (main): Delete unused variable <<c>>.
        * kill/threads.c (main): Fix prototype, exit cleanly.
        * perf/clone.c (main): Delete unused variable <<c>>..
        * kill/detach.c (main): Exit cleanly.
        * kill/suspend.c (hang): Return NULL.
        * kill/detach.c (hang): Return NULL.
        * fib/fork.c: Add missing #include <sys/types.h>, and <unistd.h>.
        * fib/exec.c: Add missing #include <unistd.h>.
        (_GNU_SOURCE): Add definition to get asprintf.
        (main): When execve fails, report an error.

Comment 2 Andrew Cagney 2006-01-26 19:50:43 UTC
Index: frysk-gtk/ChangeLog
2006-01-26  Andrew Cagney  <cagney@redhat.com>

        * Makefile.am (EggTrayIcon_libEggTrayIcon_a_CFLAGS): Delete.
        (AM_CFLAGS): Add $(GTK_CFLAGS) and $(FRYSK_GTK_CFLAGS).
Comment 3 Andrew Cagney 2006-01-26 20:29:21 UTC
Index: frysk-gtk/tlwidgets/ChangeLog
2006-01-26  Andrew Cagney  <cagney@redhat.com>

        * src/widgets/ftkconsole.c (ftk_console_new): Delete <<i>>,
        unused.
        (ftk_console_append_text_e): Return TRUE.
        * src/widgets/ftkstripchart.c (ftk_stripchart_configure): Delete
        <<ds>>, unused.
        (ftk_stripchart_expose): Delete <<d_this>>, unsed.
        (ftk_stripchart_new): Delete <<i>>, unused.
        (ftk_stripchart_expose): Cast tv_usec.
        * Makefile.am (AM_CFLAGS): Replace CFLAGS, add -Werror and -Wall.
        (libftkjni_a_SOURCES, noinst_LIBRARIES, libftkjni_so_SOURCES)
        (libftkjni.so, libftk_a_SOURCES, noinst_LIBRARIES)
        (libftk_so_SOURCES, libftk.so): Define.
        (.a.so): New rule.