This is the mail archive of the
libc-alpha@sourceware.org
mailing list for the glibc project.
Re: [BZ #12194] Fix byteswap conversion warning
On 06/20/2012 04:43 PM, Andreas Krebbel wrote:
On 06/20/2012 09:17 AM, Andreas Jaeger wrote:
The bugreport was closed in October 2010 - but only the x86 versions
were fixed but not the others as noticed today.
Here's a fix for the rest. I tested the generic functions on my system.
Ok to commit?
Andreas, you might want to cleanup the s390 functions, I'm not convinced
that the __tmp variable is needed. Could you test also the patch below,
please?
Tested on s390x - no regressions.
The byteswap.h files probably should only use software implementations which hopefully
will be recognized by GCC and replaced with hardware instructions (GCC >= 4.5.0).
Send a patch ;)
Thanks for testing!
Carlos, ok to commit for 2.16?
Andreas
--
Andreas Jaeger aj@{suse.com,opensuse.org} Twitter/Identica: jaegerandi
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 NÃrnberg, Germany
GF: Jeff Hawn,Jennifer Guild,Felix ImendÃrffer,HRB16746 (AG NÃrnberg)
GPG fingerprint = 93A3 365E CE47 B889 DF7F FED1 389A 563C C272 A126