While compiling the regex code with extra warnings on, from outside libc, quite a lot of warnings were reported. While these warnings were very justified, most of the underlying problems would not cause the actual code to behave in a non- intended way. But one is very much a bug: In find_recover_state, err is compared to REG_NOERROR, while it is *err which should be compared instead. Because of this the do-while loop will always terminate after one iteration. I was working on getting rid of all the warnings in the regex code, which was taking quite a bit of time, as I needed to make sure I'm fixing the actual problems, and not (just) the symptoms. But then I noticed that the GNU coding guidelines stopped just short of saying "Listening to warnings to find a few bugs is not worth the effort.", which would explain the mess I'm encountering. I am willing to continue my work and submit a big patch with fixes that will clean up this code somewhat, but before I continue, I'd like to know whether such a patch will actually stand a chance of getting accepted.
Subject: Re: New: bad guard in find_recover_state do-while loop >I'd like to know whether such a >patch will actually stand a chance of getting accepted. > FWIW, I'm willing to "sponsor" such a patch. You can attach it here and I'll review it even though I cannot approve it. Paolo
The referenced bug has since been fixed.