Bug 588 - am_pm patch for el_GR
Summary: am_pm patch for el_GR
Status: RESOLVED FIXED
Alias: None
Product: glibc
Classification: Unclassified
Component: localedata (show other bugs)
Version: unspecified
: P2 minor
Target Milestone: ---
Assignee: Petter Reinholdtsen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2004-11-29 10:10 UTC by Konstantinos Margaritis
Modified: 2018-04-20 14:23 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:
fweimer: security-


Attachments
el_GR am_pm patch (214 bytes, text/x-diff)
2004-11-29 10:13 UTC, Konstantinos Margaritis
Details
new updated am_pm patch (467 bytes, patch)
2005-04-30 13:23 UTC, Konstantinos Margaritis
Details | Diff
fixed patch... (438 bytes, patch)
2005-04-30 22:35 UTC, Konstantinos Margaritis
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Konstantinos Margaritis 2004-11-29 10:10:40 UTC
The attached patch is required for correct time display in el_GR locale. 
 
The am_pm variable right now is empty, for what reason I know not, but it is 
wrong in any case. 
The default time format for Greece is 12h not 24h, so it's important to have 
the necessary indications (am/pm) localized.
Comment 1 Konstantinos Margaritis 2004-11-29 10:13:40 UTC
Created attachment 295 [details]
el_GR am_pm patch
Comment 2 Simos Xenitellis 2005-02-23 13:01:55 UTC
Greece uses officially the 12-hour clock.
Source: 
http://publications.eu.int/code/el/el-4100800el.htm
(European Union Publication Service, Rules for the Greek language).

The page is in Greek. The second line in section 10.8 shows that the 12-hour
clock is the official representation of time for the Greek language/Greece.
In the document there is no distinction between the country (Greece or Cyprus),
therefore one may assume the same applies for Cyprus or el_CY locale.
Comment 3 Denis Barbier 2005-02-26 07:46:02 UTC
But all d_t_fmt, t_fmt and date_fmt fields have a 24-hr notation,
thus setting am_pm is not consistent:
  d_t_fmt  "%a %d %b %Y %T %Z"
  t_fmt    "%T"
  date_fmt "%a %b %e %H:%M:%S %Z %Y"
If you want el_GR to use a 12-hr notation, you should fix these fields
as well.
Comment 4 Konstantinos Margaritis 2005-04-30 13:23:53 UTC
Created attachment 471 [details]
new updated am_pm patch

This patch fixes the rest of the time fields so that the am/pm information
displays correctly when el_GR locale is used.
Comment 5 Konstantinos Margaritis 2005-04-30 22:35:43 UTC
Created attachment 472 [details]
fixed patch...

previous patch did not apply cleanly to cvs, thanks to Denis Barbier for the
pointer.
Comment 6 Ulrich Drepper 2005-09-24 17:53:48 UTC
Applied to CVS trunk.