Bug 4817 - Cannibalize and retire LKET tapset?
Summary: Cannibalize and retire LKET tapset?
Status: RESOLVED FIXED
Alias: None
Product: systemtap
Classification: Unclassified
Component: lket (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Srikar Dronamraju
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-19 23:51 UTC by Jim Keniston
Modified: 2007-12-10 17:10 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jim Keniston 2007-07-19 23:51:53 UTC
With the IBM China Labs guys no longer working for the LTC,
src/tapset/LKET/*.stp are suffering from neglect and resultant bit rot.  Several
outstanding bugs are associated with these files.  Many of the probepoints that
were provided only by LKET are now provided by other tapsets as well.  So
retiring LKET is looking like a definite possibility.

But before we do that, we need at least to identify the useful LKET-only
probepoints and functions, and make them available in other tapsets.
Comment 1 William Cohen 2007-08-15 19:05:36 UTC
Doing a quick grep to see what probe points are not using existing tapsets.

$ grep "kernel.function" *|more
aio.stp:        = kernel.function("sys_io_setup").return
aio.stp:        = kernel.function("io_submit_one")
aio.stp:        = kernel.function("io_submit_one").return
signal.stp:probe signal.handle = kernel.function("handle_signal")
signal.stp:probe signal.handle.return = kernel.function("handle_signal").return

Looks like the reset is based on the existing tapset probes.
Comment 2 Srikar Dronamraju 2007-08-27 14:59:08 UTC
Tapsets,Manpages and testsuite files pertaining to lket are removed.

Makefile and configure scripts are modified so that they no more look for lket
files.
References to lket from other manpages have been deleted. 

Some things that still need to be fixed.
- some probe points which were provided by LKET but are not available in
existing tapsets need to be written.

- If mysql client was only required for LKET only, then checks for mysql need to
be removed from configure script.

- If glib version >2.0 was required for lket only, then this check needs to be
removed from systemtap.spec.in file.
Comment 3 Frank Ch. Eigler 2007-08-27 20:33:31 UTC
I cleaned up the autoconf and spec files as suggested.
Comment 4 Frank Ch. Eigler 2007-12-10 17:10:10 UTC
LKET has been retired & removed.  Cannibalized?  Dunno.