Bug 4674 - Memory Window: Replace "number of bits" with "Word Size" aka "increment"
Summary: Memory Window: Replace "number of bits" with "Word Size" aka "increment"
Status: RESOLVED FIXED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on: 4623
Blocks: 3119
  Show dependency treegraph
 
Reported: 2007-06-20 17:50 UTC by Andrew Cagney
Modified: 2007-09-26 06:30 UTC (History)
1 user (show)

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Cagney 2007-06-20 17:50:07 UTC
The memory window has a tab for selecting the number of bits to display.  This
alters the "word size" used when displaying a value, but not the increment. 
Consequently, with it set to 32-bits, the table looks like (LE):

0x00000000 | 0x04030201
0x00000001 | 0x05040302

that is, regardless of this "bit size" the location always increments by 1.

Instead the "size" should determine the location increment vis:

0x00000000 | 0x04030201
0x00000004 | 0x08070605

that way the memory display forms a proper table.

During the meeting "increment" was suggested as the tab's name.  I suspect "Word
Size" would be better.
Comment 1 Andrew Cagney 2007-06-20 17:51:41 UTC
The default word size would be taken from the task's ISA
Comment 2 Andrew Cagney 2007-06-20 18:02:23 UTC
The word size doesn't affect fixed sized displays, for instance:

With the bytes
             | 8-bit
  0x00000000 | 01 02 03 04 05 06 07 08
and word size set to 32-bits would give columns:
  16-bit BE: 0102 0304
  16-bit LE: 0201 0403
  32-bit BE: 01020304
  32-bit LE: 04030201
  64-bit BE: 0102030405060708 or 0102030400000000
  64-bit LE: 0807060504030201 or 0000000004030201
  Word x86: 0x04030201
  Word ppc: 0x01020304
and word size set to 64-bits would give columns:
  16-bit BE: 0102 0304 0506 0708
  16-bit LE: 0201 0403 0605 0807
  32-bit BE: 01020304 05060708
  32-bit LE: 04030201 08070605
  64-bit BE: 0102030405060708
  64-bit LE: 0807060504030201
  Word x86: 0x0807060504030201
  Word ppc: 0x0102030405060708
Comment 3 Andrew Cagney 2007-06-20 18:23:01 UTC
*** Bug 4623 has been marked as a duplicate of this bug. ***
Comment 4 Zhao Shujing 2007-09-26 06:30:41 UTC
2007-09-25  Zhao Shujing <pearly.zhao@oracle.com>

        * memory/MemoryWindow.java: Fixes #4674.
        * gladedir/memorywindow.glade: Change adjustment to eight.