Bug 4565 - getTermwidth does not honor Terminal
Summary: getTermwidth does not honor Terminal
Status: SUSPENDED
Alias: None
Product: frysk
Classification: Unclassified
Component: general (show other bugs)
Version: unspecified
: P2 normal
Target Milestone: ---
Assignee: Unassigned
URL:
Keywords:
Depends on:
Blocks: 4054
  Show dependency treegraph
 
Reported: 2007-05-29 22:13 UTC by Stan Cox
Modified: 2009-06-11 14:05 UTC (History)
0 users

See Also:
Host:
Target:
Build:
Last reconfirmed:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stan Cox 2007-05-29 22:13:12 UTC
http://sourceforge.net/tracker/index.php?func=detail&aid=1727930&group_id=64033&atid=506056

getTermwidth does not honor Terminal.  	 
A user specified terminal is not honored by getTermwidth and getTermheight.
e.g. Given:
ConsoleReader(new FileInputStream(java.io.FileDescriptor.in),
new PrintWriter(System.out),
null,
new PtyTerminal(frysk.sys.FileDescriptor.in))

getTermwidth calls
Terminal.setupTerminal ().getTerminalWidth ();
which results in calling UnixTerminal.getTerminalWidth.

        * src/jline/ConsoleReader.java (getTermwidth): Use terminal instead of
        Terminal.setupTerminal()
        (getTermheight): Likewise.
 
Index: frysk-imports/jline/src/jline/ConsoleReader.java
===================================================================
RCS file: /cvs/frysk/frysk-imports/jline/src/jline/ConsoleReader.java,v
retrieving revision 1.2
diff -u -p -r1.2 ConsoleReader.java
--- frysk-imports/jline/src/jline/ConsoleReader.java    19 Jul 2005 15:27:55
-0000      1.2
+++ frysk-imports/jline/src/jline/ConsoleReader.java    29 May 2007 18:38:44 -0000
@@ -352,7 +352,7 @@ public class ConsoleReader
         */
        public int getTermwidth ()
        {
-               return Terminal.setupTerminal ().getTerminalWidth ();
+               return terminal.getTerminalWidth ();
        }


@@ -365,7 +365,7 @@ public class ConsoleReader
         */
        public int getTermheight ()
        {
-               return Terminal.setupTerminal ().getTerminalHeight ();
+               return terminal.getTerminalHeight ();
        }